matrix::select_k: move selection and warp-sort primitives #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achirkin
added
improvement
achirkin
force-pushed
the
enh-matrix-topk
branch
from
2e46750 to
451f232
Compare
achirkin
force-pushed
the
enh-matrix-topk
branch
from
451f232 to
fb88433
Compare
|
rerun tests |
|
Note, this PR does not add any template specialization at this point. There are two reasons for this: (1) it's not clear to which component the specializations would belong, (2) the impact on the compile times needs to be investigated more thoroughly. |
achirkin
added
3 - Ready for Review
and removed
2 - In Progress
cjnolet
requested changes
Jan 9, 2023
…void propagating the change to call sites
Codecov ReportBase: 87.99% // Head: 87.99% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1085 +/- ##
=============================================
Coverage 87.99% 87.99%
=============================================
Files 21 21
Lines 483 483
=============================================
Hits 425 425
Misses 58 58 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cjnolet
requested changes
Jan 19, 2023
cjnolet
approved these changes
Jan 21, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and move a set of implementations for batch-selecting top K largest/smallest values:
bitonic_sort.cuhto the publicraft::utilnamespace, add tests.matrix::select_kinterface.raft::spatial::knn::select_kinterface.select_ktests.select_kbenchmarks.select_warpsort.cuhto enable more implementations.Closes #853