Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude changelog from pre-commit spellcheck #1083

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Exclude changelog from pre-commit spellcheck #1083

merged 1 commit into from
Dec 8, 2022

Conversation

benfred
Copy link
Member

@benfred benfred commented Dec 8, 2022 •
edited
Loading

Exclude the changelog from the pre-commit codespell check- this is to prevent CI failures after release when the changelog is updated, as suggested here rapidsai/cudf#12097 (review)

This also exports the __version__ for pylibraft / raft_dask, which was missing previously

@benfred
Exclude changelog from pre-commit spellcheck
96f7fd6 
Exclude the changelog from the pre-commit changelog - this is to prevent
CI failures after release when the changelog is updated, as suggested
here rapidsai/cudf#12097 (review)

This also exports the `__version__` for pylibraft / raft_dask, which was missing
previously
@benfred benfred requested a review from a team as a code owner December 8, 2022 21:58
@github-actions github-actions bot added the python label Dec 8, 2022
@benfred benfred added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Dec 8, 2022
@benfred
Copy link
Member Author

benfred commented Dec 8, 2022

This is to avoid failures like #1080 -

@cjnolet
Copy link
Member

cjnolet commented Dec 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 266deb5 into rapidsai:branch-23.02 Dec 8, 2022
@benfred benfred deleted the exclude_changelog branch December 9, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benfred @cjnolet