Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cython fixes / cleanup #1072

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Minor cython fixes / cleanup #1072

merged 1 commit into from
Dec 7, 2022

Conversation

benfred
Copy link
Member

@benfred benfred commented Dec 7, 2022

  • Release GIL on C++ cython declarations
  • Remove 'valid values for metric' mention from the compute_new_centroids docstring (since it doesn't take a metric parameter)
  • Remove is_c_cont in favour of input_validation.is_c_contiguous in kmeans.pyx

@benfred
Minor cython fixes / cleanup
aee90f4 
* Release GIL on C++ cython declarations
* Remove ‘valid values for metric’ from compute_new_centroids (since doesn’t take a metric param)
* Remove is_c_cont in favour of is_c_contiguous in kmeans.pyx
@benfred benfred added the non-breaking Non-breaking change label Dec 7, 2022
@benfred benfred requested a review from a team as a code owner December 7, 2022 01:18
@github-actions github-actions bot added the python label Dec 7, 2022
@benfred benfred added the improvement Improvement / enhancement to an existing function label Dec 7, 2022
cjnolet
cjnolet approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@benfred
Copy link
Member Author

benfred commented Dec 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dd49a10 into rapidsai:branch-23.02 Dec 7, 2022
@benfred benfred deleted the minor_cython_cleanup branch December 7, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benfred @cjnolet