Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial port of auto-find-k #1070

Merged
merged 26 commits into from
Feb 21, 2023
Merged

Initial port of auto-find-k #1070

merged 26 commits into from
Feb 21, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Dec 6, 2022 •
edited
Loading

This is a port of rapidsai/cuml#818 (originally from NVGraph) which uses the Calinski-Harabasz score
to find the optimal value of k.

Todo:

  • create histogram of cluster sizes
  • add googletests
  • expose public API

Closes #825

cc @jeaton32

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 6, 2022
@cjnolet cjnolet requested a review from a team as a code owner December 6, 2022 01:31
@cjnolet cjnolet self-assigned this Dec 6, 2022
@github-actions github-actions bot added the cpp label Dec 6, 2022
@cjnolet cjnolet requested a review from a team as a code owner December 8, 2022 16:04
@github-actions github-actions bot added the CMake label Dec 8, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Dec 13, 2022

rerun tests

@github-actions github-actions bot removed the CMake label Feb 16, 2023
@cjnolet cjnolet changed the base branch from branch-23.02 to branch-23.04 February 16, 2023 15:53
@github-actions github-actions bot added the CMake label Feb 17, 2023
benfred
benfred reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good!

Some minor comments:

cpp/include/raft/cluster/detail/kmeans_auto_find_k.cuh Outdated Show resolved Hide resolved
cpp/include/raft/cluster/detail/kmeans_auto_find_k.cuh Outdated Show resolved Hide resolved
benfred
benfred approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cjnolet
Copy link
Member Author

cjnolet commented Feb 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit bbfb869 into rapidsai:branch-23.04 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfred benfred benfred approved these changes

Assignees

@cjnolet cjnolet

Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Kmeans auto-find K
2 participants
@cjnolet @benfred