IVF-PQ: tweak launch configuration #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achirkin
added
improvement
achirkin
added
3 - Ready for Review
and removed
2 - In Progress
|
NB: with this update, there still were observed couple cases where the reference implementation was faster by 5-9%; in all of them the raft ivf-pq kernel was faster, and the slowdown came from the other part - select-top-k block kernel (selecting the candidate clusters for search). |
tfeher
approved these changes
Dec 8, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add one more criterion for reducing the block size when selecting the optimal launch configuration. This fixes a few benchmark cases where the performance has been slightly worse compared to the reference implementation.