Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused setuputils modules #1053

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Remove unused setuputils modules #1053

merged 2 commits into from
Nov 30, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 29, 2022

The functionality in these modules is no longer used by setup.py due to refactorings done to use scikit-build and to support building wheels.

@vyasr vyasr added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 29, 2022
@vyasr vyasr requested a review from a team as a code owner November 29, 2022 21:35
@vyasr vyasr self-assigned this Nov 29, 2022
benfred
benfred approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@vyasr
Copy link
Contributor Author

vyasr commented Nov 29, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0d76264 into rapidsai:branch-23.02 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfred benfred benfred approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @benfred