Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor CUDA versions in dependencies.yaml #327

Merged
merged 1 commit into from
Jan 11, 2024
Merged

refactor CUDA versions in dependencies.yaml #327

merged 1 commit into from
Jan 11, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#7.

Proposes splitting the cuda-version dependency in dependencies.yaml out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

Benefits of this change

  • prevents accidental inclusion of multiple cuda-version version in environments
  • reduces update effort (via enabling more use of globs like "12.*")
  • improves the chance that errors like "conda recipe is missing a dependency" are caught in CI

@jameslamb jameslamb mentioned this pull request Jan 10, 2024
Closed
4 tasks
@jakirkham jakirkham added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 11, 2024
jakirkham
jakirkham approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 🙏

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a93175b into rapidsai:branch-24.02 Jan 11, 2024
33 checks passed
@jameslamb jameslamb deleted the rework-dependencies branch January 11, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @jakirkham