Zarr Compressor Benchmark #276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
madsbk
force-pushed
the
zarr_compressor_benchmark
branch
from
d534deb to
48c95ca
Compare
akshaysubr
reviewed
Oct 23, 2023
akshaysubr
left a comment
akshaysubr
left a comment
There was a problem hiding this comment.
Wanted to chime in with a couple of minor comments that I had as I was going through this PR
|
|
||
| t0 = clock() | ||
| compressor.codec.decode(a, out=dst) | ||
| decode_time = clock() - t0 |
There was a problem hiding this comment.
This probably needs some GPU synchronization before measuring end time, doesn't it?
| compressors = { | ||
| "lz4-default": Compressor(device=Device.CPU, codec=numcodecs.LZ4()), | ||
| "lz4-blosc": Compressor( | ||
| device=Device.CPU, codec=numcodecs.blosc.Blosc(cname="lz4") |
There was a problem hiding this comment.
The default for Blosc is shuffle=SHUFFLE which changes the compression ratio a fair bit compared to LZ4. Might be good to indicate that in the str naming?
| "snappy-nvcomp": Compressor(device=Device.GPU, codec=kvikio.zarr.Snappy()), | ||
| "cascaded-nvcomp": Compressor(device=Device.GPU, codec=kvikio.zarr.Cascaded()), | ||
| "gdeflate-nvcomp": Compressor(device=Device.GPU, codec=kvikio.zarr.Gdeflate()), | ||
| "bitcomp-nvcomp": Compressor(device=Device.GPU, codec=kvikio.zarr.Bitcomp()), |
There was a problem hiding this comment.
Bitcomp requires the dtype which currently isn't an option here but is an option in BitcompManager. Might be good to expose that and add it here if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.