Subcharts declared in subfolders under charts/ are ignored

Frigate currently only considers Chart.yaml declared dependencies, but ignores subcharts directly located under the charts/ folder. I don't run into issues about this, but it is a broken expectation on how frigate works if I would use frigate on a helm chart wish subcharts and not just chart dependencies.

https://github.com/rapidsai/frigate/blob/4153bf5d737894dd381402306456a7ba80d0de5f/frigate/gen.py#L58-L74

	root = [] if root is None else root
	chart, values = load_chart(chartdir, root=root)
	if "dependencies" in chart:
	for dependency in chart["dependencies"]:
	dependency_name = dependency["name"]
	dependency_path = os.path.join(
	chartdir, "charts", f"{dependency_name}-{dependency['version']}.tgz",
	)
	with tempfile.TemporaryDirectory() as tmpdirname:
	shutil.unpack_archive(dependency_path, tmpdirname)
	dependency_dir = os.path.join(tmpdirname, dependency_name)

	update_chart_dependencies(tmpdirname, dependency_name)
	_, dependency_values = load_chart_with_dependencies(
	dependency_dir, root + [dependency_name]
	)
	values = squash_duplicate_values(values + dependency_values)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subcharts declared in subfolders under charts/ are ignored #49

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development