Skip to content

Build args in dockerfiles should not use realistic values #100

@jameslamb

Description

Description

Dockerfiles in this repo currently set realistic values as defaults for build arguments

ARG CUDA_VER=11.8.0
ARG LINUX_VER=ubuntu20.04
ARG PYTHON_VER=3.10

But never intentionally use those defaults... it's always expected that those build arguments will be fulfilled by values passed through to docker build:

echo "docker build --pull -t ${BUILD_IMAGE}:${BUILD_TAG} ${BUILD_ARGS} ${BUILD_DIR}"

Those realistic values should be replaced with the literal string unset or similar.

Benefits of this work

Reduces the risk of silently building and tagging an image that's using the wrong configuration (because of mistakes in passing through build args).

Acceptance Criteria

  • all configuration for build arguments is driver from outside of Dockerfiles

Approach

This: rapidsai/docker#689 (comment)

Notes

Created this issue based on #97 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions