Skip to content

Treat clobber warnings as errors for conda builds #54

Open
0 of 1 issue completed
Open
@jameslamb

Description

(Apr 23, 2024) moved from an internal tracking board. The description here is @ajschmidt8 's original write-up of the issue.

Problem

Some of our conda builds suffer from ClobberWarnings (e.g. here and here).

Ignoring these clobber warnings can sometimes result in packaging issues. Therefore, we'd like to begin treating these clobber warnings as errors.

Ideally, this setting should go in the .condarc file of our CI images (i.e. here) so that it applies to every RAPIDS repository.

However, since many repositories already suffer from clobber warnings, this would break CI for a lot of people.

Therefore, we need to plan the rollout carefully.

Solution

To roll out this new configuration setting safely, we should do the following:

For each of the repositories in the section below:

a. Open a PR and add the following line to any build scripts (e.g. ci/build_{cpp,python}.sh): conda config --set path_conflict prevent
b. Resolve any build issues that result from this change
c. If build issues occur, fix them and merge the PR (leaving in the new conda config line, that will be cleaned up later)
d. If no build issues occur, simply close the PR
e. Link the PR in this issue (do not link this issue in the PR, since this issue is in a private repository)

Once all of the repositories are successfully using the new conda config setting, add the setting to https://github.com/rapidsai/ci-imgs/blob/main/context/condarc.tmpl

Go back and clean up all of the extraneous conda config --set path_conflict prevent lines in each repository

Repositories

Look at the repos at this search query.

Sub-issues

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions