Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DESTDIR embedded in recap LIBDIR #195

Closed
tonyskapunk opened this issue Jan 25, 2019 · 1 comment
Closed

DESTDIR embedded in recap LIBDIR #195

tonyskapunk opened this issue Jan 25, 2019 · 1 comment
Labels
bug enhancement
Milestone
2.0.1

Comments

@tonyskapunk
Copy link
Contributor

When attempting to build a RPM for recap it is detected that the DESTDIR(BUILDROOT in rpm context) is embedded in the recap script:

$ fedpkg local


Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.LiHZBS
+ umask 022
+ cd /home/tonyskapunk/recap
+ cd /home/tonyskapunk/recap
+ rm -rf recap-2.0.0
+ /usr/bin/gzip -dc /home/tonyskapunk/recap/recap-2.0.0.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd recap-2.0.0
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.XZgH5x
+ umask 022
+ cd /home/tonyskapunk/recap
+ '[' /home/tonyskapunk/rpm/BUILDROOT/recap-2.0.0-1.fc30.x86_64 '!=' / ']'
+ rm -rf /home/tonyskapunk/rpm/BUILDROOT/recap-2.0.0-1.fc30.x86_64
++ dirname /home/tonyskapunk/rpm/BUILDROOT/recap-2.0.0-1.fc30.x86_64
+ mkdir -p /home/tonyskapunk/rpm/BUILDROOT
+ mkdir /home/tonyskapunk/rpm/BUILDROOT/recap-2.0.0-1.fc30.x86_64
+ cd recap-2.0.0
+ export PREFIX=/usr
+ PREFIX=/usr
+ export DESTDIR=/home/tonyskapunk/rpm/BUILDROOT/recap-2.0.0-1.fc30.x86_64
+ DESTDIR=/home/tonyskapunk/rpm/BUILDROOT/recap-2.0.0-1.fc30.x86_64
+ make install-base
Installing scripts...
Installing libraries...
Installing configuration...
Creating log directories...
+ make install-man
Installing man pages...
+ make install-cron
Installing cron job...
+ '[' noarch = noarch ']'
+ case "${QA_CHECK_RPATHS:-}" in
+ /usr/lib/rpm/check-buildroot
/home/tonyskapunk/rpm/BUILDROOT/recap-2.0.0-1.fc30.x86_64/usr/sbin/recap:declare -r LIBDIR="/home/tonyskapunk/rpm/BUILDROOT/recap-2.0.0-1.fc30.x86_64/usr/lib/recap"
Found '/home/tonyskapunk/rpm/BUILDROOT/recap-2.0.0-1.fc30.x86_64' in installed files; aborting
error: Bad exit status from /var/tmp/rpm-tmp.XZgH5x (%install)
    Bad exit status from /var/tmp/rpm-tmp.XZgH5x (%install)


RPM build errors:
Could not execute local: rpmbuild --define '_sourcedir /home/tonyskapunk/recap' --define '_specdir /home/tonyskapunk/recap' --define '_builddir /home/tonyskapunk/recap' --define '_srcrpmdir /home/tonyskapunk/recap' --define '_rpmdir /home/tonyskapunk/recap' --define 'dist .fc30' --define 'fedora 30' --eval '%undefine rhel' --define 'fc30 1' --eval '%undefine fc29' -ba /home/tonyskapunk/recap/recap.spec | tee .build-2.0.0-1.fc30.log
@tonyskapunk tonyskapunk mentioned this issue Jan 25, 2019
Merged
@tonyskapunk tonyskapunk added this to the 2.0.1 milestone Feb 1, 2019
@tonyskapunk
Copy link
Contributor Author

Fixed in #196 will be included in a new release of recap

This was referenced Feb 3, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
1 participant
@tonyskapunk