Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weird extra keycode being send if release LT() before another key #1370

Closed
dunkarooftop opened this issue Jun 7, 2017 · 5 comments
Closed

weird extra keycode being send if release LT() before another key #1370

dunkarooftop opened this issue Jun 7, 2017 · 5 comments

Comments

@dunkarooftop
Copy link

dunkarooftop commented Jun 7, 2017 •
edited
Loading

I downloaded the latest version few days ago and recompile the keyboard and found this issues, not sure if it's something wrong on my end or it's a new bug. say

Base layer: character "A" lay on top of Number layer: "1"
When I pressed the key to enter Number layer (let's call it Numb Key here)

If I press down Numb Key, then tap "A" then release Numb Key will send "1" which is what we want.
But
if I press down Numb, -> press down "A", (send "1") -> let go of Numb Key, -> let go "A" key (send "a").

I don't think it used to behave this way can someone try it and see if this happen to too thanks :)
@dunkarooftop
Copy link
Author

turn out it's cause by enabling the combo, the problem go away after I disable it. The combo function is still a bit buggy #960

@dunkarooftop dunkarooftop mentioned this issue Jun 7, 2017
Merged
@fredizzimo
Copy link
Contributor

I don't know what's wrong, but I can check this more carefully at some point.

I think many things are getting quite complex, especially in how different features interact with each other, in this case the tapping and combo, so I really think we need to get some unit tests added, to both help with the implementation, and to make sure that nothing breaks.

@fredizzimo
Copy link
Contributor

I think I found the issue, and commented on the pull request. But because it's not easy to fix I suggest that you don't use the same keys for LT and combos.

@dunkarooftop
Copy link
Author

@fredizzimo
Thank you for looking into it and thank all the team who work hard for the community : )

@drashna
Copy link
Member

drashna commented Mar 25, 2018

Sounds like this is resolved?

If not, then please reopen or open a new issue.

@drashna drashna closed this as completed Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drashna @fredizzimo @dunkarooftop