Selenium 3 move_to_element issue fix with event firing webdriver (robotframework#1438)

aaltat · web-flow · commit d72372b79dd5 · 2019-08-30T20:13:01.000+03:00
Fixes robotframework#1435
diff --git a/atest/acceptance/2-event_firing_webdriver/event_firing_webdriver.robot b/atest/acceptance/2-event_firing_webdriver/event_firing_webdriver.robot
@@ -1,17 +1,10 @@
 *** Settings ***
 Library           SeleniumLibrary    event_firing_webdriver=${CURDIR}/MyListener.py
+Resource          resource_event_firing_webdriver.robot
 Suite Setup       Open Browser    ${FRONT PAGE}    ${BROWSER}    alias=event_firing_webdriver
 ...                   remote_url=${REMOTE_URL}    desired_capabilities=${DESIRED_CAPABILITIES}
 Suite Teardown    Close All Browsers
 
-*** Variable ***
-${SERVER}=                  localhost:7000
-${BROWSER}=                 Chrome
-${REMOTE_URL}=              ${NONE}
-${DESIRED_CAPABILITIES}=    ${NONE}
-${ROOT}=                    http://${SERVER}/html
-${FRONT_PAGE}=              ${ROOT}/
-
 *** Test Cases ***
 Open Browser To Start Page
     [Tags]    NoGrid
diff --git a/atest/acceptance/2-event_firing_webdriver/resource_event_firing_webdriver.robot b/atest/acceptance/2-event_firing_webdriver/resource_event_firing_webdriver.robot
@@ -0,0 +1,7 @@
+*** Variables ***
+${SERVER}=                  localhost:7000
+${BROWSER}=                 Chrome
+${REMOTE_URL}=              ${NONE}
+${DESIRED_CAPABILITIES}=    ${NONE}
+${ROOT}=                    http://${SERVER}/html
+${FRONT_PAGE}=              ${ROOT}/
diff --git a/atest/acceptance/2-event_firing_webdriver/selenium_move_to_workaround.robot b/atest/acceptance/2-event_firing_webdriver/selenium_move_to_workaround.robot
@@ -0,0 +1,24 @@
+*** Settings ***
+Documentation    Can be deleted when minimum Selenium version 4.0
+Library          SeleniumLibrary     event_firing_webdriver=${CURDIR}/MyListener.py
+Resource         resource_event_firing_webdriver.robot
+Force Tags       NoGrid
+Suite Setup      Open Browser    ${FRONT PAGE}    ${BROWSER}    alias=event_firing_webdriver
+...              remote_url=${REMOTE_URL}    desired_capabilities=${DESIRED_CAPABILITIES}
+
+*** Test Cases ***
+Selenium move_to workaround Click Element At Coordinates
+    [Documentation]    LOG 1:5 DEBUG  Workaround for Selenium 3 bug.
+    Click Element At Coordinates    id:some_id    4    4
+
+Selenium move_to workaround Scroll Element Into View
+    [Documentation]    LOG 1:4 DEBUG  Workaround for Selenium 3 bug.
+    Scroll Element Into View    id:some_id
+
+Selenium move_to workaround Mouse Out
+    [Documentation]    LOG 1:8 DEBUG  Workaround for Selenium 3 bug.
+    Mouse Out    id:some_id
+
+Selenium move_to workaround Mouse Over
+    [Documentation]    LOG 1:5 DEBUG  Workaround for Selenium 3 bug.
+    Mouse Over    id:some_id
diff --git a/src/SeleniumLibrary/keywords/element.py b/src/SeleniumLibrary/keywords/element.py
@@ -627,7 +627,13 @@ def click_element_at_coordinates(self, locator, xoffset, yoffset):
                   % (locator, xoffset, yoffset))
         element = self.find_element(locator)
         action = ActionChains(self.driver)
-        action.move_to_element(element)
+        # Try/except can be removed when minimum required Selenium is 4.0 or greater.
+        try:
+            action.move_to_element(element)
+        except AttributeError:
+            self.debug('Workaround for Selenium 3 bug.')
+            element = element.wrapped_element
+            action.move_to_element(element)
         action.move_by_offset(xoffset, yoffset)
         action.click()
         action.perform()
@@ -666,7 +672,13 @@ def scroll_element_into_view(self, locator):
         New in SeleniumLibrary 3.2.0
         """
         element = self.find_element(locator)
-        ActionChains(self.driver).move_to_element(element).perform()
+        # Try/except can be removed when minimum required Selenium is 4.0 or greater.
+        try:
+            ActionChains(self.driver).move_to_element(element).perform()
+        except AttributeError:
+            self.debug('Workaround for Selenium 3 bug.')
+            element = element.wrapped_element
+            ActionChains(self.driver).move_to_element(element).perform()
 
     @keyword
     def drag_and_drop(self, locator, target):
@@ -732,7 +744,14 @@ def mouse_out(self, locator):
         offsetx = (size['width'] / 2) + 1
         offsety = (size['height'] / 2) + 1
         action = ActionChains(self.driver)
-        action.move_to_element(element).move_by_offset(offsetx, offsety)
+        # Try/except can be removed when minimum required Selenium is 4.0 or greater.
+        try:
+            action.move_to_element(element)
+        except AttributeError:
+            self.debug('Workaround for Selenium 3 bug.')
+            element = element.wrapped_element
+            action.move_to_element(element)
+        action.move_by_offset(offsetx, offsety)
         action.perform()
 
     @keyword
@@ -745,7 +764,13 @@ def mouse_over(self, locator):
         self.info("Simulating Mouse Over on element '%s'." % locator)
         element = self.find_element(locator)
         action = ActionChains(self.driver)
-        action.move_to_element(element).perform()
+        # Try/except can be removed when minimum required Selenium is 4.0 or greater.
+        try:
+            action.move_to_element(element).perform()
+        except AttributeError:
+            self.debug('Workaround for Selenium 3 bug.')
+            element = element.wrapped_element
+            action.move_to_element(element).perform()
 
     @keyword
     def mouse_up(self, locator):
