Skip to content

Commit 161d549

Browse files
authored
Remove two manual steps to edit python.org pages (#308)
1 parent f408a38 commit 161d549

File tree

2 files changed

+0
-119
lines changed

2 files changed

+0
-119
lines changed

run_release.py

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import argparse
1010
import asyncio
1111
import contextlib
12-
import datetime as dt
1312
import functools
1413
import getpass
1514
import json
@@ -1110,38 +1109,6 @@ def purge_the_cdn(db: ReleaseShelf) -> None:
11101109
raise RuntimeError("Failed to purge the python.org/downloads CDN")
11111110

11121111

1113-
def modify_the_prereleases_page(db: ReleaseShelf) -> None:
1114-
if db["release"].is_final:
1115-
if not ask_question(
1116-
"Have you already removed the release from https://www.python.org/download/pre-releases/ ?"
1117-
):
1118-
raise ReleaseException(
1119-
"The release has not been removed from the pre-releases page"
1120-
)
1121-
else:
1122-
if not ask_question(
1123-
"Have you already added the release to https://www.python.org/download/pre-releases/ ?"
1124-
):
1125-
raise ReleaseException(
1126-
"The release has not been added to the pre-releases page"
1127-
)
1128-
1129-
1130-
def modify_the_docs_by_version_page(db: ReleaseShelf) -> None:
1131-
if db["release"].is_final:
1132-
version = db["release"]
1133-
date = dt.datetime.now().strftime("%d %B %Y")
1134-
if not ask_question(
1135-
"Have you already added the docs to https://www.python.org/doc/versions/ ?\n"
1136-
"For example:\n"
1137-
f"* `Python {version} <https://docs.python.org/release/{version}/>`_, "
1138-
f"documentation released on {date}."
1139-
):
1140-
raise ReleaseException(
1141-
"The docs have not been added to the docs by version page"
1142-
)
1143-
1144-
11451112
def announce_release(db: ReleaseShelf) -> None:
11461113
if not ask_question(
11471114
"Have you announced the release at https://discuss.python.org/c/core-dev/23 "
@@ -1478,8 +1445,6 @@ def _api_key(api_key: str) -> str:
14781445
Task(remove_temporary_branch, "Removing temporary release branch"),
14791446
Task(run_add_to_python_dot_org, "Add files to python.org download page"),
14801447
Task(purge_the_cdn, "Purge the CDN of python.org/downloads"),
1481-
Task(modify_the_prereleases_page, "Modify the pre-release page"),
1482-
Task(modify_the_docs_by_version_page, "Update docs by version page"),
14831448
Task(announce_release, "Announce the release"),
14841449
]
14851450
automata = ReleaseDriver(

tests/test_run_release.py

Lines changed: 0 additions & 84 deletions
Original file line numberDiff line numberDiff line change
@@ -147,90 +147,6 @@ def test_check_doc_unreleased_version_waived(monkeypatch, tmp_path: Path) -> Non
147147
run_release.check_doc_unreleased_version(cast(ReleaseShelf, db))
148148

149149

150-
@pytest.mark.parametrize(
151-
["tag", "expected"],
152-
[
153-
("3.14.0a7", "Have you already added the release to "),
154-
("3.13.3", "Have you already removed the release from "),
155-
],
156-
)
157-
def test_modify_the_prerelease_page_yes(
158-
capsys, monkeypatch, tag: str, expected: str
159-
) -> None:
160-
# Arrange
161-
db = {"release": Tag(tag)}
162-
163-
# Act
164-
with fake_answers(monkeypatch, ["yes"]):
165-
run_release.modify_the_prereleases_page(cast(ReleaseShelf, db))
166-
167-
# Assert
168-
assert expected in capsys.readouterr().out
169-
170-
171-
@pytest.mark.parametrize(
172-
["tag", "expected"],
173-
[
174-
("3.14.0a7", "The release has not been added to the pre-releases page"),
175-
("3.13.3", "The release has not been removed from the pre-releases page"),
176-
],
177-
)
178-
def test_modify_the_prerelease_page_no(monkeypatch, tag: str, expected: str) -> None:
179-
# Arrange
180-
db = {"release": Tag(tag)}
181-
182-
# Act
183-
with (
184-
fake_answers(monkeypatch, ["no"]),
185-
pytest.raises(run_release.ReleaseException, match=expected),
186-
):
187-
run_release.modify_the_prereleases_page(cast(ReleaseShelf, db))
188-
189-
190-
def test_modify_the_docs_by_version_page_prerelease(capsys) -> None:
191-
# Arrange
192-
db = {"release": Tag("3.14.0a7")}
193-
194-
# Act
195-
run_release.modify_the_docs_by_version_page(cast(ReleaseShelf, db))
196-
197-
# Assert
198-
assert capsys.readouterr().out == ""
199-
200-
201-
def test_modify_the_docs_by_version_page_final_no(capsys, monkeypatch) -> None:
202-
# Arrange
203-
db = {"release": Tag("3.13.3")}
204-
205-
# Act
206-
with (
207-
fake_answers(monkeypatch, ["no"]),
208-
pytest.raises(run_release.ReleaseException),
209-
):
210-
run_release.modify_the_docs_by_version_page(cast(ReleaseShelf, db))
211-
212-
# Assert
213-
assert (
214-
"* `Python 3.13.3 <https://docs.python.org/release/3.13.3/>`_, documentation released on"
215-
in capsys.readouterr().out
216-
)
217-
218-
219-
def test_modify_the_docs_by_version_page_final_yes(capsys, monkeypatch) -> None:
220-
# Arrange
221-
db = {"release": Tag("3.13.3")}
222-
223-
# Act
224-
with fake_answers(monkeypatch, ["yes"]):
225-
run_release.modify_the_docs_by_version_page(cast(ReleaseShelf, db))
226-
227-
# Assert
228-
assert (
229-
"* `Python 3.13.3 <https://docs.python.org/release/3.13.3/>`_, documentation released on"
230-
in capsys.readouterr().out
231-
)
232-
233-
234150
def test_update_whatsnew_toctree(tmp_path: Path) -> None:
235151
# Arrange
236152
# Only first beta triggers update

0 commit comments

Comments
 (0)