-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add PowerShell support #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PowerShell support #2749
Conversation
Tests can be run with Look at the existing tests for the files you've changed to get an idea of what they do. They're basically Bash scripts with some extra syntax that denotes tests and setup/teardown code that's preprocessed and then executed by Bats. We're using a rather old Bats version, 1.2.0, the docs are at https://github.com/bats-core/bats-core/blob/v1.2.0/README.md . Apart from functions defined by Bats, we use additional ones defined in Most tests are unit tests that mock any external interactions; IIRC in the affected files, there're only 1-2 integration tests for Fish. |
@pyenv/pyenv-core-maintainers IMO supporting PowerShell is fine. However, due to unfamiliarity with it, we may need to request help if more stuff interacting with it will be needed in the future or problems are reported. |
native-api
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures look like bona fide bugs in the code
Make sure you have checked all steps below.
Prerequisite
Description
I added support for PowerShell (on Linux), it could probably be implemented for rbenv also, however I never used ruby and don't feel confident to implement it.
I know it's maybe a patch too important for the core code, if so just close this (draft) PR.
Tests
I don't know how BATS works, I need help / hints to understand what should I do -- where is the tested shell specified?