Deque's maxlen property dropped on V1 validation (#6586)

maciekglowka · web-flow · commit 2aaddf6d692a · 2023-07-11T16:21:46.000+02:00
diff --git a/changes/6581-maciekglowka.md b/changes/6581-maciekglowka.md
@@ -0,0 +1 @@
+Fixes the `maxlen` property being dropped on `deque` validation. Happened only if the deque item has been typed. Changes the `_validate_sequence_like` func.
diff --git a/pydantic/fields.py b/pydantic/fields.py
@@ -943,7 +943,7 @@ def _validate_sequence_like(  # noqa: C901 (ignore complexity)
         elif self.shape == SHAPE_TUPLE_ELLIPSIS:
             converted = tuple(result)
         elif self.shape == SHAPE_DEQUE:
-            converted = deque(result)
+            converted = deque(result, maxlen=getattr(v, 'maxlen', None))
         elif self.shape == SHAPE_SEQUENCE:
             if isinstance(v, tuple):
                 converted = tuple(result)
@@ -952,7 +952,7 @@ def _validate_sequence_like(  # noqa: C901 (ignore complexity)
             elif isinstance(v, Generator):
                 converted = iter(result)
             elif isinstance(v, deque):
-                converted = deque(result)
+                converted = deque(result, maxlen=getattr(v, 'maxlen', None))
         return converted, None
 
     def _validate_iterable(
diff --git a/tests/test_types.py b/tests/test_types.py
@@ -3123,6 +3123,25 @@ class Model(BaseModel):
     assert Model(v=value).v == result
 
 
+def test_deque_maxlen():
+    class DequeTypedModel(BaseModel):
+        field: Deque[int] = deque(maxlen=10)
+
+    assert DequeTypedModel(field=deque(maxlen=25)).field.maxlen == 25
+    assert DequeTypedModel().field.maxlen == 10
+
+    class DequeUnTypedModel(BaseModel):
+        field: deque = deque(maxlen=10)
+
+    assert DequeUnTypedModel(field=deque(maxlen=25)).field.maxlen == 25
+    assert DequeTypedModel().field.maxlen == 10
+
+    class DeuqueNoDefaultModel(BaseModel):
+        field: deque
+
+    assert DeuqueNoDefaultModel(field=deque(maxlen=25)).field.maxlen == 25
+
+
 @pytest.mark.parametrize(
     'cls,value,errors',
     (

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fixes the `maxlen` property being dropped on `deque` validation. Happened only if the deque item has been typed. Changes the `_validate_sequence_like` func.