-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why didn't a yarn error trigger a failure in GitHub Actions? node version mismatch #1705
Comments
When comparing the same or similar code (i believe, this was hours earlier than the above error, and merged), we saw no such error. But i think that's because default node version on GitHub Actions was higher than v13? https://github.com/publiclab/mapknitter/runs/6374206383?check_suite_focus=true The yarn error above was: Do we need to do more to sync node versions? |
Yes, GitHub Actions uses at least node v16! https://github.blog/changelog/2021-12-10-github-actions-github-hosted-runners-now-run-node-js-16-by-default/ and indeed we just switched to v16 to fix this issue, as it's a LTS version. Should we fix this? |
Note that Jenkins doesn't run the tests. And Google Cloud is yet another environment, although it will probably use the same files in |
there is dockerfile support for GH Actions, makes sense... we could converge a bit... but is it worth it? https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions |
Noting that we had a similar error of node v12 on production when we tried to publish the #1712 changes, somehow it's not v16 on production again...?
|
Will try setting this here: Line 48 in da8ec9d
|
Originally posted by @jywarren in #1688 (comment)
We saw this error in a Jenkins build, and yet on its own it did not trigger a GitHub Actions failure:
The text was updated successfully, but these errors were encountered: