A few cosmetic fixes #858
A few cosmetic fixes #858
Conversation
It's already included from box64context.h. Since there's no pthread.h on Win32, including it only once avoids having to add ifdefs everywhere.
To avoid 'function declaration is not a prototype' warnings when using -Wstrict-prototypes.
It's not used, and conflicts with the original Zydis headers.
|
a PE build ... of box64? are you plugin box64 in wine peloader or something like that? removing elfloader and using something PE oriented instead? |
|
What I'm trying to do is basically use only the emulator parts, and plug it into the existing wow64 support, so syscalls go to Wow64SystemServiceEx which takes care of 32->64 transitions, and Wine handles everything else on the 64-bit side. |
|
Nice. Signals are also probably a bit tricky too. |
by that do you mean you trying to build wine on ARM64 with |
All we really need from the emulator is to fetch the current context, all signal handling is done on the Wine side. When the exception needs to be handled in 32-bit we reenter emulation through KiUserExceptionDispatcher. It seems to work OK in emulation mode, but I haven't tried dynarec yet. |
Yes, the Unix interfaces and ntdll are aarch64, the rest is x86 PE code running through emulation. For x64 the plan is to implement ARM64EC and have basically all of Wine run as native ARM code, but the ARM64EC toolchain is not ready yet. |
|
Small question from me. Is it going to work with wineandroid.drv? |
It should work fine, but wineandroid.drv is pretty much abandoned at the moment, someone will have to pick it up again. Maybe emulation support will create some new motivation to maintain it... |
A few cosmetic fixes for things spotted while trying to do a PE build under Wine. These should all be no-ops.