Skip to content

Update Phabricator to v1beta3 example #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikhiljindal merged 1 commit into from
Apr 23, 2015
Merged

Update Phabricator to v1beta3 example #7232

nikhiljindal merged 1 commit into from
Apr 23, 2015

Conversation

@bcbroussard
Copy link
Contributor

@bcbroussard bcbroussard commented Apr 23, 2015

Small part of #6584.

@bcbroussard bcbroussard changed the title Phabricator example Update Phabricator to v1beta3 example Apr 23, 2015
@nikhiljindal nikhiljindal self-assigned this Apr 23, 2015
nikhiljindal
nikhiljindal reviewed Apr 23, 2015
View reviewed changes
examples/phabricator/v1beta3/phabricator-controller.json Outdated
Copy link
Contributor

@nikhiljindal nikhiljindal Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default value and hence can be deleted to keep the example short and simple.

@bcbroussard
Copy link
Contributor Author

bcbroussard commented Apr 23, 2015

@nikhiljindal - updated with your comments addressed.

nikhiljindal
nikhiljindal reviewed Apr 23, 2015
View reviewed changes
examples/phabricator/README.md Outdated
Copy link
Contributor

@nikhiljindal nikhiljindal Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can delete this.

@nikhiljindal
Copy link
Contributor

nikhiljindal commented Apr 23, 2015

Thanks! Mostly LGTM with a few nits.
Please squash your commits so that I can merge.

@bcbroussard bcbroussard force-pushed the phabricator-example branch from ad55857 to 715bee6 Compare April 23, 2015 18:47
@bcbroussard
Copy link
Contributor Author

bcbroussard commented Apr 23, 2015

Removed the unnecessary imagePullPolicy and squashed. I had left them in since they were in the original v1beta1. Should be good to go.

@nikhiljindal
Copy link
Contributor

nikhiljindal commented Apr 23, 2015

Thanks. Will merge once travis/shippable turns green

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2015
nikhiljindal added a commit that referenced this pull request Apr 23, 2015
@nikhiljindal
Merge pull request #7232 from bcbroussard/phabricator-example
67b5b08 
Update Phabricator to v1beta3 example
@nikhiljindal nikhiljindal merged commit 67b5b08 into kubernetes:master Apr 23, 2015
@bcbroussard bcbroussard deleted the phabricator-example branch May 28, 2015 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikhiljindal nikhiljindal

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bcbroussard @nikhiljindal @googlebot