Add a common debug flag envvar #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| chef.cookbooks_path = "chef/cookbooks" | ||
| config.vm.provision :chef_solo do |chef| | ||
| chef.cookbooks_path = "chef/cookbooks" | ||
| chef.log_level = :debug unless ENV['PROVISO_DEBUG'].nil? |
There was a problem hiding this comment.
Was thinking about replacing
chef.log_level = :debug unless ENV['PROVISO_DEBUG'].nil?with
chef.log_level = :debug if debug_mode?And pulling the methods out into lib/priviso/helper.rb or something. I figure if we build this like a real ruby project (ie. a gem), we might eventually want to package it up as a CLI tool. Anyhow, that's definitely a larger point of discussion, but would anyone be in favour of making the code more self-documenting like suggested above, or would a lib/ directory be overboard?
|
Oh hey, this is just built on the puppet branch, since the future merge would have been messy. I can rebase after that's merged |
|
@patcon any chance you could refactor since this is merged? ^^ |
|
I think I could do that -- shouldn't be too bad :) I've assigned it to myself for later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug output in kalastack seemed really useful:
https://github.com/kalamuna/kalastack/blob/2.x/Vagrantfile#L112
Thought it might be nice to have this extra provisioner output off by default, but enabled with a single command:
https://github.com/patcon/kalastack/blob/develop/Vagrantfile#L109
https://github.com/patcon/kalastack/blob/develop/Vagrantfile#L121
PR pending