Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering clusters by tenant #195

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Fix filtering clusters by tenant #195

merged 1 commit into from
Sep 2, 2022

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Sep 2, 2022

Fixes #95

Filters clusters by tenant using the syn.tools/tenant label added by the operator on reconcile.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues.

@bastjan bastjan requested a review from glrf September 2, 2022 10:49
glrf
glrf approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that was even less effort than I expected 😅

pkg/service/cluster.go Outdated Show resolved Hide resolved
@bastjan bastjan merged commit 84846c0 into master Sep 2, 2022
@bastjan bastjan deleted the tenant-filter branch September 2, 2022 11:45
@bastjan bastjan added the bug Something isn't working label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glrf glrf glrf approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering clusters by tenant does not work
2 participants
@bastjan @glrf