Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission for lieutenant to list secrets #190

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Add permission for lieutenant to list secrets #190

merged 1 commit into from
Aug 3, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Aug 3, 2022 •
edited
Loading

With #187 we need to be able to list secrets. That permission was forgotten.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues.

@glrf glrf added the bug Something isn't working label Aug 3, 2022
@glrf glrf self-assigned this Aug 3, 2022
@glrf glrf marked this pull request as ready for review August 3, 2022 12:40
@glrf glrf requested a review from bastjan August 3, 2022 12:40
@glrf glrf merged commit 6a81720 into master Aug 3, 2022
@glrf glrf deleted the fix/permission-secret-list branch August 3, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

@bastjan bastjan Awaiting requested review from bastjan

Assignees

@glrf glrf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glrf @simu