Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:Delete the link of operator.md #5521

Merged
merged 1 commit into from
Jun 23, 2023
Merged

docs:Delete the link of operator.md #5521

merged 1 commit into from
Jun 23, 2023

Conversation

yanggangtony
Copy link
Contributor

image
image

labels: ["release-note/none-required"]

@yanggangtony yanggangtony requested a review from a team as a code owner June 22, 2023 22:34
@yanggangtony yanggangtony requested review from tsaarni and stevesloka and removed request for a team June 22, 2023 22:34
@yanggangtony
Copy link
Contributor Author

/release-note none-required

@skriss
Copy link
Member

skriss commented Jun 22, 2023

@yanggangtony the Operator is no longer maintained, so these were removed intentionally. Is there a broken link or something else that led you to believe these should exist?

@skriss
Copy link
Member

skriss commented Jun 22, 2023

Ah I see, the entry in the table of contents still exists. Can you remove it, instead of adding the page back? Thanks

@codecov
Copy link

codecov bot commented Jun 22, 2023 •
edited
Loading

Codecov Report

Merging #5521 (edd36c6) into main (32510de) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5521   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files         138      138           
  Lines       18798    18798           
=======================================
  Hits        14723    14723           
  Misses       3792     3792           
  Partials      283      283

@yanggangtony
Copy link
Contributor Author

@skriss
Thanks for quick review.
Yes , the table of contents still exists.
I will remove the table links.

@yanggangtony yanggangtony changed the title docs:Add missing docs for operator.md docs:Delete the link of operator.md Jun 22, 2023
@yanggangtony
Copy link
Contributor Author

@skriss
Rebased.
Hi, Thanks for review.
I have deleted the link in site/data/docs/main-toc.yml.
The ohter relelease version is not necessary , As it is had operator before.

@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jun 23, 2023
@sunjayBhatia sunjayBhatia merged commit 6a65909 into projectcontour:main Jun 23, 2023
@yanggangtony
Copy link
Contributor Author

Thanks.

@yanggangtony yanggangtony deleted the fix-docs-operator branch June 23, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka is a code owner automatically assigned from projectcontour/maintainers

Assignees
No one assigned
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanggangtony @skriss @sunjayBhatia