/sem-approve

@yanggangtony, did you try building Calico with this go-build change to see if there are any errors or not?

did you try building Calico with this go-build change to see if there are any errors or not?
@frozenprocess
Hi , thanks for review.
Actually i known go-build is calico's outer inference , i saw that is the branch tag?
like

/calico/metadata.mk  , 
# The version of github.com/projectcalico/go-build to use.
GO_BUILD_VER = v0.78

I am also a newbie to calico community.

How did it test local code for that?

did you try building Calico with this go-build change to see if there are any errors or not?
@frozenprocess
Hi , thanks for review.
Actually i known go-build is calico's outer inference , i saw that is the branch tag?
like

/calico/metadata.mk  , 
# The version of github.com/projectcalico/go-build to use.
GO_BUILD_VER = v0.78

I am also a newbie to calico community.

Welcome!
I would highly recommend checking the #contributors channel in the Calico Users Slack group. It is the place to share, ask and connect with other devs and engineers to talk Calico!

How did it test local code for that?

It is pretty easy,

# clone https://github.com/projectcalico/calico
make image all CALICO_BUILD=myrepo/myimage:mytag

@frozenprocess
thanks for the patient.
I will test it recently and response my result here.
👌

1 first i build go-build in my local pc .

then get images about :

2 : build calico project

when build arm image in my amd64 machine, docker buildx can not do it , it get error before pic.

so maybe i should found a arm64 machine to test that ? is that right? if that , then will also to search ppc64le and s390x 's matchine , that will become very difficult to test.
is there a good way to test cross image for calico build?

I ended up building each image individually

make image CALICO_BUILD=rezareza/go-build:latest
make image ARCH=arm64 CALICO_BUILD=rezareza/go-build:latest-arm64
make image ARCH=s390x CALICO_BUILD=rezareza/go-build:latest-s390x
make image ARCH=armv7 CALICO_BUILD=rezareza/go-build:latest-armv7
make image ARCH=ppc64le CALICO_BUILD=rezareza/go-build:latest

so maybe i should found a arm64 machine to test that ? is that right? if that , then will also to search ppc64le and s390x 's matchine , that will become very difficult to test.

Nope, QEMU should take care of it, but it seems like after the monorepo change the CALICO_BUILD argument is not correctly passed on, I have to dig deeper tho.

is there a good way to test cross image for calico build?

Seems like a no atm, but I'll review it if you can figure out why it's not happening 😈

Thank you for your contribution!