-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key TTL support #2
Comments
Hi Maciej, we really appreciate that you let us know your thoughts. There are 2 ways to handle key expiration.
In both cases, there should be a separate offline GC job that manages TTL bookkeeping, and issues mutations (for # 1 TTL updates, for # 2 deletes) to servers. In our opinion # 2 has quite a few advantages, major ones being:
That explains why there is no TTL mentioned in the current data format. Regarding manual updating: The original API was a HTTP API so the idea was that there will be an update server accepting update requests and through some medium (e.g., files) the updates get persisted and propagated to the real bidding/scoring server. The current implementation is still part of that vision. However, the offline garbage collection job (and the update server) is currently a low priority thing for us because that is something Adtech users can implement on their own. The current file-based server updates accept direct deletes, so it still follows the same direction. Right now our main focus is the critical serving path. |
The former Key Value Server Mutating API specification included key expiration: https://github.com/WICG/turtledove/pull/350/files?short_path=f7e0d97.
I think it made sense as interest groups referring to these keys are expiring from browser.
IIUC, current implementation requires removing keys manually.
The text was updated successfully, but these errors were encountered: