-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Marketing Typography #583
Conversation
Did a little research on how other design systems serve fonts. Solid Since InterUI is open source, I'm leaning towards the first option: writing documentation for how to install it on a project rather than including it within Primer. Any suggestions @primer/ds-core? |
Just my two cents: Inter UI doesn't support a monospace font I think, and it's a little weird how Rasmus's website is displaying and styling the typeface itself: There isn't a differentiation between display and body text for Inter-UI, and I believe the designer is doing it manually through the styling Apple's -apple-system auto corrects between SF Pro Display and SF Pro Text, I think: I think Inter-UI might be a headache for teams to go in manually to declare styling... but there could be information I'm missing! |
Hey @jhuashao - thanks for your comment!
Luckily, we're only using Inter for headings (and only on Marketing sites). Body copy on any marketing site will use the system font stack that is used on the rest of GitHub. Same thing goes for mono, so we aren't defining anything special for marketing sites and it can match with the product. My biggest question at the moment is what is the best approach for installing the font files. I personally think it would be best to link directly to https://github.com/rsms/inter/releases/tag/v3.0 and providing documentation, but I agree that this manual approach could be a headache! |
I agree, and I think that we should at least consider distributing all of the web-ready files ( |
just wanted to leave a note here that there are still some as well as probably a handful of subdomains that are using them too, e.g. Partners site i have some spare time between projects and will open a PR shortly to update in |
@@ -221,7 +221,7 @@ | |||
|
|||
/* Set to monospace font */ | |||
.text-mono { | |||
font-family: $mono-font; | |||
font-family: $mono-font !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a note for my commit:
!important is needed in order for the monospace font to have effect with other marketing headers, e.g. h2-mktg
when you want a big monospace header like on github.com/ten https://github.com/github/github/pull/102693#discussion_r236315756
https://github.com/github/github/pull/102693/files#diff-20a6e07f77d51d5f093dded1d213d52dR70
Hi friends! Drive-by lurker here. 👋 I'm curious what prompted the decision to replace Roboto with InterUI. |
This comment has been minimized.
This comment has been minimized.
I just added the font files to this PR! @shawnbot has written an awesome sync tool https://github.com/primer/sync#readme that will move all scss from I think that wraps up all thats needed for this PR! if we can get another review/sanity check please 👀 |
Okay, so here's the catch with |
Okay, I'm going to test this out with |
Hey @zeke
Sorry to not respond sooner! I think the main driver for us to switch was mostly based on the visual design of InterUI and how it went well with with our new marketing site design direction. We also introduced a new monospaced font in our marketing design as well (SF Mono) and needed a display/header type that would work well with it; Roboto didnt fit the tone/personality we were going for anymore. We landed on Inter UI as it paired well with everything and is also open source and free, which is important to our heavily trafficked sites. :) Hopefully I didnt leave any other more important reason for our switch unaccounted for cc/ @primer/github-site-design if i missed anything! |
Quick follow-up: |
This PR starts to work some of GitHub's recent site design changes back into Primer, starting with typography. It does the following:
alt-
to suffixed with-mktg
. This is more descriptive for how they are to be used, the packages they are in, and matches other Primer naming conventions.h000
size, extra biggo$alt-mono-font
because we don't need two mono-fontsalt-text-small
sincef5
does the same thingTo-do:
/cc @primer/ds-core & @trosage (who wrote most of this in
github/github
)