Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase input font-size to 16px on mobile #430

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Increase input font-size to 16px on mobile #430

merged 1 commit into from
Jan 13, 2018

Conversation

broccolini
Copy link
Member

@broccolini broccolini commented Jan 12, 2018 •
edited
Loading

This pr fixes https://github.com/github/design-systems/issues/405

It gives the input field a font-size of 16px on mobile from the md breakpoint and up it will have 14px, this means inputs won't zoom in on mobile on responsive pages.

To do:

  • test in github/github
    • mobile
    • tablet
    • desktop

cc @primer/design-systems @kevinsawicki

@broccolini broccolini changed the title increase input font-size to 16px on mobile Increase input font-size to 16px on mobile Jan 12, 2018
@broccolini broccolini mentioned this pull request Jan 12, 2018
Closed
17 tasks
kevinsawicki
kevinsawicki approved these changes Jan 12, 2018
View reviewed changes
Copy link

@kevinsawicki kevinsawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@broccolini
Copy link
Member Author

Despite what the status check says, the alpha version is 10.3.0-alpha.9c5fbfd8

@broccolini
Copy link
Member Author

Tested in review-lab https://input-size.review-lab.github.com/

  • Doesn't seem to cause any unwanted behavoir on dotcom. If you reduce your screensize to a super narrow window the font-size will increase but doesn't effect the size of the input field so it doesn't cause any problems with layout.
  • It was difficult to test a real scenario on iPad and mobile without a new responsive layout, however it didn't cause any problems with the current site on dotcom product and site pages.

@broccolini broccolini merged commit 37a4787 into release-10.3.0 Jan 13, 2018
@broccolini broccolini deleted the input_fs branch January 13, 2018 00:19
This was referenced Mar 21, 2018
Merged
Closed
@kevinsawicki kevinsawicki mentioned this pull request Jul 23, 2018
Closed
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
@github-actions github-actions bot mentioned this pull request Dec 22, 2022
Open
This was referenced Jan 1, 2023
Open
Open
This was referenced Jan 8, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinsawicki kevinsawicki kevinsawicki approved these changes

Assignees
No one assigned
Labels
minor release Tag: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@broccolini @kevinsawicki