Skip to content

Dynamic Dialog: log ERROR when closable is false or not set #16852

Closed
@aboudard

Description

Describe the bug

When running an open method on DialogService, is you set [closable] to false, or omit the input, the console is logging an ERROR like this:
ERROR RangeError: Maximum call stack size exceeded
image

Environment

Local environnement Windows 11, reproduced on StackBlitz, see below

Reproducer

https://stackblitz.com/edit/github-5euggt?file=src%2Fapp%2Fapp.component.ts

Angular version

18.1.0

PrimeNG version

18.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

Chrome 131

Steps to reproduce the behavior

Run the project, click on the button, check the console in devtools.

Expected behavior

Should not log an ERROR in any case.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

Type

No type

Projects

  • Status

    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions