Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same print width for range formatting as normal formatting. #6050

Merged
merged 2 commits into from
May 4, 2019
Merged

Use same print width for range formatting as normal formatting. #6050

merged 2 commits into from
May 4, 2019

Conversation

mathieulj
Copy link
Contributor

@mathieulj mathieulj commented Apr 11, 2019 •
edited
Loading

Fixes an issue were a file would end up formatted differently with ranged formatting (--range-start & --range-end) versus normal whole file formatting.

Fixes #6046

  • I’ve added tests to confirm my change works.
  • (n/a) (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

mathieulj added 2 commits May 4, 2019 09:12
@mathieulj
Use same print width for range formatting as normal formatting.
4f2dea4 
Fixes an issue were a file would end up formatted differently
with ranged formatting (--range-start & --range-end) versus
normal whole file formatting.
@mathieulj
Document range bugfix in changelog.
02a3895
@mathieulj
Copy link
Contributor Author

Rebased on top of upstream master to resolve conflicts.

@j-f1 j-f1 merged commit 26183e5 into prettier:master May 4, 2019
@j-f1
Copy link
Member

j-f1 commented May 4, 2019

Thank you for contributing!

@xcomponentadmin xcomponentadmin mentioned this pull request May 13, 2019
Closed
@automatops automatops mentioned this pull request May 13, 2019
Merged
1 task
This was referenced Jun 5, 2019
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Open
Closed
Closed
Merged
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ranged formatting doesn't match whole file formatting.
2 participants
@mathieulj @j-f1