Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: update typescript-estree to new package name (#5799)" #5818

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Revert "chore: update typescript-estree to new package name (#5799)" #5818

merged 2 commits into from
Jan 31, 2019

Conversation

ikatyang
Copy link
Member

Reverts commit 1143619 in 1.16 branch as a temporary workaround for #5817.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.16.3 milestone Jan 31, 2019
@ikatyang ikatyang force-pushed the revert/typescript/new-typescript-eslint branch from f79dd15 to e01a060 Compare January 31, 2019 03:39
@ikatyang
Copy link
Member Author

Not sure why there's no CI triggered but I've tested it locally and it worked.

@ikatyang ikatyang merged commit fc93bbc into prettier:release-1.16 Jan 31, 2019
@ikatyang ikatyang deleted the revert/typescript/new-typescript-eslint branch January 31, 2019 03:43
@ikatyang ikatyang mentioned this pull request Jan 31, 2019
Closed
@automatops automatops mentioned this pull request Jan 31, 2019
Merged
1 task
@ghost ghost mentioned this pull request Jan 31, 2019
Merged
1 task
@xcomponentadmin xcomponentadmin mentioned this pull request Jan 31, 2019
Merged
@ikatyang ikatyang mentioned this pull request Feb 2, 2019
Closed
3 tasks
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label May 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.16.3
Development

Successfully merging this pull request may close these issues.
1 participant
@ikatyang