Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(javascript): fix locEnd for VariableDeclaration caused by --no-semi #5434

Merged
merged 2 commits into from
Nov 10, 2018
Merged

fix(javascript): fix locEnd for VariableDeclaration caused by --no-semi #5434

merged 2 commits into from
Nov 10, 2018

Conversation

ikatyang
Copy link
Member

Fixes #5409

There should be a lot of places could be fixed by this kind of method but I just want to fix the regression one for now.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 10, 2018
@j-f1
Copy link
Member

j-f1 commented Nov 10, 2018

Ooh, could this finally fix #1510?

@ikatyang
Copy link
Member Author

Probably, but we need to fix it case-by-case.

@ikatyang ikatyang merged commit 7e72889 into prettier:master Nov 10, 2018
@ikatyang ikatyang deleted the fix/javascript/no-semi-comment branch November 10, 2018 16:26
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lipis lipis lipis approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.15.2
Development

Successfully merging this pull request may close these issues.

Comments on lines before leading semis are indented in 1.15.1
3 participants
@ikatyang @j-f1 @lipis