Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(html): treat capital element as custom element #5395

Merged
merged 2 commits into from
Nov 9, 2018
Merged

feat(html): treat capital element as custom element #5395

merged 2 commits into from
Nov 9, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Nov 8, 2018

Fixes #5385

Custom element: keep it on its own line if both leading/trailing line breaks exist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 8, 2018
@j-f1
Copy link
Member

j-f1 commented Nov 8, 2018

What if someone writes <BODY> (etc.)? Are those still lowercased?

@ikatyang
Copy link
Member Author

ikatyang commented Nov 8, 2018

Yes, known html elements are lowercased in the parse step.

prettier/src/language-html/parser-html.js

Lines 92 to 122 in fd8ec95

const lowerCaseIfFn = (text, fn) => {
const lowerCasedText = text.toLowerCase();
return fn(lowerCasedText) ? lowerCasedText : text;
};
const normalizeName = node => {
if (node instanceof Element) {
if (
!node.namespace ||
node.namespace === node.tagDefinition.implicitNamespacePrefix
) {
node.name = lowerCaseIfFn(
node.name,
lowerCasedName => lowerCasedName in HTML_TAGS
);
}
const CURRENT_HTML_ELEMENT_ATTRIBUTES =
HTML_ELEMENT_ATTRIBUTES[node.name] || Object.create(null);
node.attrs.forEach(attr => {
if (!attr.namespace) {
attr.name = lowerCaseIfFn(
attr.name,
lowerCasedAttrName =>
node.name in HTML_ELEMENT_ATTRIBUTES &&
(lowerCasedAttrName in HTML_ELEMENT_ATTRIBUTES["*"] ||
lowerCasedAttrName in CURRENT_HTML_ELEMENT_ATTRIBUTES)
);
}
});
}
};

@ikatyang ikatyang merged commit 9acb029 into prettier:master Nov 9, 2018
@ikatyang ikatyang deleted the feat/html/treat-capital-element-as-custom-element branch November 9, 2018 01:51
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-f1 j-f1 j-f1 approved these changes

@duailibe duailibe duailibe approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.15.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ikatyang @j-f1 @duailibe