fix(multiparser): no additional trailing newline for graphql in js #4616

ikatyang · 2018-05-31T16:25:18Z

The root cause is the output doc from graphql printer does not match the desired input from stripTrailingHardline.

Lines 167 to 180 in a9b21a0

    
           function stripTrailingHardline(doc) { 
        
             // HACK remove ending hardline, original PR: #1984 
        
             if ( 
        
               doc.type === "concat" && 
        
               doc.parts.length === 2 && 
        
               doc.parts[1].type === "concat" && 
        
               doc.parts[1].parts.length === 2 && 
        
               doc.parts[1].parts[0].hard && 
        
               doc.parts[1].parts[1].type === "break-parent" 
        
             ) { 
        
               return doc.parts[0]; 
        
             } 
        
             return doc; 
        
           }

Prettier pr-4616
Playground link

--parser babylon

Input:

graphql`
  fragment x on y {
    z
  }

  fragment a on b {
    c
  }
`;

Output:

graphql`
  fragment x on y {
    z
  }

  fragment a on b {
    c
  }
`;

vjeux

Thanks! Fortunately the workaround for this hack isn't too bad.

175: Update dependency prettier to v1.13.4 r=rehandalal a=renovate[bot] This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.3` to `v1.13.4` <details> <summary>Release Notes</summary> ### [`v1.13.4`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#1134) [Compare Source](prettier/prettier@1.13.3...1.13.4) [link](prettier/prettier@1.13.3...1.13.4) - Fix a regression when printing graphql-in-js ([#4616](`https://github.com/prettier/prettier/pull/4616`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <[email protected]>

ikatyang added 2 commits June 1, 2018 00:18

test: add tests

6ae627d

fix(multiparser): no additional trailing newline for graphql in js

9fce9ce

ikatyang requested a review from vjeux May 31, 2018 16:28

vjeux approved these changes May 31, 2018

View reviewed changes

ikatyang merged commit b55997e into prettier:master May 31, 2018

ikatyang deleted the fix/graphql-trailing-newline branch May 31, 2018 16:38

lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 29, 2018

lock bot locked as resolved and limited conversation to collaborators Aug 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(multiparser): no additional trailing newline for graphql in js #4616

fix(multiparser): no additional trailing newline for graphql in js #4616

ikatyang commented May 31, 2018 •

edited

Loading

vjeux left a comment

	function stripTrailingHardline(doc) {
	// HACK remove ending hardline, original PR: #1984
	if (
	doc.type === "concat" &&
	doc.parts.length === 2 &&
	doc.parts[1].type === "concat" &&
	doc.parts[1].parts.length === 2 &&
	doc.parts[1].parts[0].hard &&
	doc.parts[1].parts[1].type === "break-parent"
	) {
	return doc.parts[0];
	}
	return doc;
	}

fix(multiparser): no additional trailing newline for graphql in js #4616

fix(multiparser): no additional trailing newline for graphql in js #4616

Conversation

ikatyang commented May 31, 2018 • edited Loading

vjeux left a comment

Choose a reason for hiding this comment

ikatyang commented May 31, 2018 •

edited

Loading