-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flow] Fix union indent inside of function param with a name #4325
Conversation
Fixes prettier#4323 See prettier#4323 for all the context
append( | ||
options?: | ||
| string | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this look better as options?: string | {
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, I only do the printing for undefined and null. We could extend it. I wanted to err on the safe side.
@suchipi: would you be able to cut 1.12.1 with this change by any chance? I really want to get the new release out to Facebook :p |
@vjeux can do |
@vjeux 1.12.1 is released |
yay! |
@suchipi thanks so much for the quick turnaround time! |
You're welcome 😃 |
Fixes #4323
See #4323 for all the context.
I'd love to get it merged and ship a dot release if possible with it. It's affecting a bunch of code and prevents upgrading to the latest version of prettier at Facebook. I know it's been there for a while (since 1.9.3...)