Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flow] Fix union indent inside of function param with a name #4325

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

vjeux
Copy link
Contributor

@vjeux vjeux commented Apr 16, 2018

Fixes #4323

See #4323 for all the context.

I'd love to get it merged and ship a dot release if possible with it. It's affecting a bunch of code and prevents upgrading to the latest version of prettier at Facebook. I know it's been there for a while (since 1.9.3...)

@vjeux vjeux requested review from suchipi and duailibe April 16, 2018 23:43
append(
options?:
| string
| {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this look better as options?: string | {?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, I only do the printing for undefined and null. We could extend it. I wanted to err on the safe side.

@vjeux vjeux merged commit 02a1db8 into prettier:master Apr 17, 2018
@vjeux
Copy link
Contributor Author

vjeux commented Apr 17, 2018

@suchipi: would you be able to cut 1.12.1 with this change by any chance? I really want to get the new release out to Facebook :p

@suchipi
Copy link
Member

suchipi commented Apr 17, 2018

@vjeux can do

@suchipi
Copy link
Member

suchipi commented Apr 17, 2018

@vjeux 1.12.1 is released

@zertosh
Copy link
Member

zertosh commented Apr 17, 2018

yay!

@vjeux
Copy link
Contributor Author

vjeux commented Apr 17, 2018

@suchipi thanks so much for the quick turnaround time!

@suchipi
Copy link
Member

suchipi commented Apr 17, 2018

You're welcome 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants