Avoid to break after assignment for call expression that has complex type parameters #10949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn0
reviewed
May 25, 2021
src/language-js/print/assignment.js
Outdated
| const hasComplexTypeParams = | ||
| node.typeParameters && | ||
| isNonEmptyArray(node.typeParameters.params) && | ||
| willBreak(print("typeParameters")); |
There was a problem hiding this comment.
Please add one more condition: if there is more than one type argument, the call shouldn't be considered "poorly breakable".
There was a problem hiding this comment.
And another case: the only type argument is a union type.
thorn0
reviewed
May 26, 2021
src/language-js/print/assignment.js
Outdated
| function isCallExpressionWithComplexTypeParameters(node, print) { | ||
| if ( | ||
| isCallExpression(node) && | ||
| node.typeParameters && |
There was a problem hiding this comment.
In Flow AST, it's typeArguments instead of typeParameters
thorn0
reviewed
May 27, 2021
src/language-js/print/assignment.js
Outdated
| return false; | ||
| } | ||
|
|
||
| function getTypeParametersFromCallExpression(node) { |
There was a problem hiding this comment.
Suggested change
| function getTypeParametersFromCallExpression(node) { | |
| function getCallExpressionTypeArguments(node) { |
There was a problem hiding this comment.
'arguments' in this case is a more correct word
thorn0
reviewed
May 27, 2021
src/language-js/print/assignment.js
Outdated
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| function getTypeParametersFromCallExpression(node) { | ||
| function getTypeArgumentsFromCallExpression(node) { | ||
| if (isCallExpression(node)) { |
There was a problem hiding this comment.
As long as this function isn't used anywhere else this check is redundant.
thorn0
approved these changes
May 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(I made a mistake in the branch name)
Fixes #10846
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨