Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prettier/prettier
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7e31610
Choose a base ref
...
head repository: prettier/prettier
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6f5df0e
Choose a head ref
  • 12 commits
  • 31 files changed
  • 4 contributors

Commits on Jan 13, 2017

  1. Fix CHANGELOG format

    jlongster committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    2ab030b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ffdb0c View commit details
    Browse the repository at this point in the history
  3. Update live editor to 0.0.6

    jlongster committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    3713408 View commit details
    Browse the repository at this point in the history
  4. Adds various prettier-browser changes (#175)

    * Adds link to GH repo in title
    
    * Adds popular keybindings (subl) to editor
    
    * Changes theme to base16-dark to fit better with body bg
    mikaelbr authored and jlongster committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    cbabefd View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2017

  1. Fix [(0)] (#179)

    Another issue where babylon and flow ast are different. In babylon, it is NumericLiteral but flow is Literal. All the tests are running on flow so were working correctly, but the default in the command line is to use babylon, so people report bugs with it.
    vjeux authored and jlongster committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    ca47108 View commit details
    Browse the repository at this point in the history
  2. Do not advance for forward skipSpaces (#176)

    For backward, we should go one step back, but for forward we are already in the correct place. It doesn't change any tests.
    vjeux authored and jlongster committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    23e6184 View commit details
    Browse the repository at this point in the history
  3. Fix windows line-endings (#177)

    The search for an empty line incorrectly does +1 which happens to be skipping a `\n`, but in case of windows line endings it skips the `\r` but sees a `\n` afterwards and incorrectly assumes that it is a empty line.
    
    This doesn't change the behavior of doing +1 when there's not a line ending. Making it correct actually triggers a bunch of changes, where half of them are better and half of them regressions. So I'm going to send another pull request to fix that case.
    vjeux authored and jlongster committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    b9a3e06 View commit details
    Browse the repository at this point in the history
  4. add license to package.json (#178)

    Because right now it doesn't show any license on
    [the npm page](https://www.npmjs.com/package/prettier).
    
    Also, it's causing my [DependencyCI](https://dependencyci.com/github/kentcdodds/prettier-eslint/builds/5)
    build to fail 😅
    Kent C. Dodds authored and jlongster committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    f49111c View commit details
    Browse the repository at this point in the history
  5. Fix exponent in babylon (#181)

    The type is NumericLiteral instead of Literal
    vjeux authored and jlongster committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    ca230c2 View commit details
    Browse the repository at this point in the history
  6. Make declare type consistent between babylon and flow (#183)

    Flow doesn't have a different ast node for `type` and `declare type`. Let's always use the heuristic to be inside of a `declare module` for both ast. This way more snapshot tests are passing between the two parsers.
    vjeux authored and jlongster committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    3134b1c View commit details
    Browse the repository at this point in the history
  7. Fix DeclareInterface (#182)

    DeclareInterface (flow) and InterfaceDeclaration (babylon) are the same type so should behave the same way. I am using the same `declare` trick where I only add it if you are inside of a `declare module` block.
    vjeux authored and jlongster committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    d8c5148 View commit details
    Browse the repository at this point in the history
  8. Change test to workaround babylon bug (#184)

    Babylon has a bug where it doesn't escape DirectiveLiteral properly. Except for `'use strict';`, this never happens in real world code, so let's put strings in a array in order to workaround this bug and have the same output on both parsers.
    
    babel/babylon#289
    vjeux authored and jlongster committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    6f5df0e View commit details
    Browse the repository at this point in the history
Loading