-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Comparing changes
Open a pull request
base repository: prettier/prettier
base: 7e31610
head repository: prettier/prettier
compare: 6f5df0e
- 12 commits
- 31 files changed
- 4 contributors
Commits on Jan 13, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 2ab030b - Browse repository at this point
Copy the full SHA 2ab030bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ffdb0c - Browse repository at this point
Copy the full SHA 4ffdb0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3713408 - Browse repository at this point
Copy the full SHA 3713408View commit details -
Adds various prettier-browser changes (#175)
* Adds link to GH repo in title * Adds popular keybindings (subl) to editor * Changes theme to base16-dark to fit better with body bg
Configuration menu - View commit details
-
Copy full SHA for cbabefd - Browse repository at this point
Copy the full SHA cbabefdView commit details
Commits on Jan 14, 2017
-
Another issue where babylon and flow ast are different. In babylon, it is NumericLiteral but flow is Literal. All the tests are running on flow so were working correctly, but the default in the command line is to use babylon, so people report bugs with it.
Configuration menu - View commit details
-
Copy full SHA for ca47108 - Browse repository at this point
Copy the full SHA ca47108View commit details -
Do not advance for forward skipSpaces (#176)
For backward, we should go one step back, but for forward we are already in the correct place. It doesn't change any tests.
Configuration menu - View commit details
-
Copy full SHA for 23e6184 - Browse repository at this point
Copy the full SHA 23e6184View commit details -
Fix windows line-endings (#177)
The search for an empty line incorrectly does +1 which happens to be skipping a `\n`, but in case of windows line endings it skips the `\r` but sees a `\n` afterwards and incorrectly assumes that it is a empty line. This doesn't change the behavior of doing +1 when there's not a line ending. Making it correct actually triggers a bunch of changes, where half of them are better and half of them regressions. So I'm going to send another pull request to fix that case.
Configuration menu - View commit details
-
Copy full SHA for b9a3e06 - Browse repository at this point
Copy the full SHA b9a3e06View commit details -
add license to package.json (#178)
Because right now it doesn't show any license on [the npm page](https://www.npmjs.com/package/prettier). Also, it's causing my [DependencyCI](https://dependencyci.com/github/kentcdodds/prettier-eslint/builds/5) build to fail 😅
Configuration menu - View commit details
-
Copy full SHA for f49111c - Browse repository at this point
Copy the full SHA f49111cView commit details -
Fix exponent in babylon (#181)
The type is NumericLiteral instead of Literal
Configuration menu - View commit details
-
Copy full SHA for ca230c2 - Browse repository at this point
Copy the full SHA ca230c2View commit details -
Make
declare typeconsistent between babylon and flow (#183)Flow doesn't have a different ast node for `type` and `declare type`. Let's always use the heuristic to be inside of a `declare module` for both ast. This way more snapshot tests are passing between the two parsers.
Configuration menu - View commit details
-
Copy full SHA for 3134b1c - Browse repository at this point
Copy the full SHA 3134b1cView commit details -
DeclareInterface (flow) and InterfaceDeclaration (babylon) are the same type so should behave the same way. I am using the same `declare` trick where I only add it if you are inside of a `declare module` block.
Configuration menu - View commit details
-
Copy full SHA for d8c5148 - Browse repository at this point
Copy the full SHA d8c5148View commit details -
Change test to workaround babylon bug (#184)
Babylon has a bug where it doesn't escape DirectiveLiteral properly. Except for `'use strict';`, this never happens in real world code, so let's put strings in a array in order to workaround this bug and have the same output on both parsers. babel/babylon#289
Configuration menu - View commit details
-
Copy full SHA for 6f5df0e - Browse repository at this point
Copy the full SHA 6f5df0eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7e31610...6f5df0e