Issue upgrading to Prettier 3 #562

broksonic21 · 2023-07-05T13:15:36Z

What version of eslint are you using?
8.44.0

What version of prettier are you using?
3.0.0

What version of eslint-plugin-prettier are you using?
4.2.1

Please paste any applicable config files that you're using (e.g. .prettierrc or .eslintrc files)

/* eslint-env node */

module.exports = {
  plugins: ["@typescript-eslint", "prettier"],

  extends: [
    "eslint:recommended",
    "plugin:@typescript-eslint/eslint-recommended",
    "plugin:@typescript-eslint/recommended",
  ],
  rules: {
    "prettier/prettier": "error",
  },
  settings: {
    "import/resolver": {
      typescript: {
        alwaysTryTypes: true,
      },
    },
  },
};

What source code are you linting?
private source code

What did you expect to happen?
Can run with prettier 3 like with prettier 2

What actually happened?

✖ eslint --quiet --fix:

Oops! Something went wrong! :(

ESLint: 8.44.0

TypeError: prettier.resolveConfig.sync is not a function
Occurred while linting REDACTED
Rule: "prettier/prettier"
    at Program (/Users/REDACTED/REDACTED/REDACTED/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js:138:40)
    at ruleErrorHandler (/Users/REDACTED/REDACTED/REDACTED/node_modules/eslint/lib/linter/linter.js:1050:28)
    at /Users/REDACTED/REDACTED/REDACTED/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/REDACTED/REDACTED/REDACTED/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/Users/REDACTED/REDACTED/REDACTED/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (/Users/REDACTED/REDACTED/REDACTED/node_modules/eslint/lib/linter/node-event-generator.js:326:22)
    at NodeEventGenerator.enterNode (/Users/REDACTED/REDACTED/REDACTED/node_modules/eslint/lib/linter/node-event-generator.js:340:14)
    at CodePathAnalyzer.enterNode (/Users/REDACTED/REDACTED/REDACTED/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:795:23)
    at /Users/REDACTED/REDACTED/REDACTED/node_modules/eslint/lib/linter/linter.js:1085:32

The text was updated successfully, but these errors were encountered:

shogo82148 · 2023-07-05T13:22:45Z

I got same error on reviewdog/action-golangci-lint#561 (comment)
The whole of log is here: https://github.com/reviewdog/action-golangci-lint/actions/runs/5464628836/jobs/9946920478?pr=561

sandrooco · 2023-07-05T13:43:46Z

V5 pre-release actually adds support for this. I'm shocked this has been in September last year... @JounQin can you provide information about the future of this package? Thanks for your work!

isimmons · 2023-07-05T16:00:16Z

Same issue both for running eslint in a package.json script and vscode eslint output from the extension. Fixed by downgrading prettier to version 2.8.8

ali4heydari · 2023-07-05T16:10:57Z

prettier.resolveConfigFile.sync is removed from version 3 of prettier.

@sandrooco I tried version ^5.0.0-alpha.1 and I got this error:

Cannot read properties of undefined (reading 'parsers')
Occurred while linting path/to/file:1
Rule: "prettier/prettier"

Dependencies:

    "@typescript-eslint/eslint-plugin": "^5.61.0",
    "@typescript-eslint/parser": "^5.61.0",
    "eslint": "8.44.0",
    "eslint-config-next": "^13.4.8",
    "eslint-config-prettier": "^8.8.0",
    "eslint-plugin-cypress": "^2.13.3",
    "eslint-plugin-jest": "^27.2.2",
    "eslint-plugin-no-relative-import-paths": "^1.5.2",
    "eslint-plugin-prettier": "^5.0.0-alpha.1",
    "prettier": "^3.0.0",
    "prettier-plugin-tailwindcss": "^0.3.0",
     "typescript": "^5.1.6",

ali4heydari · 2023-07-05T16:18:12Z

prettier.resolveConfigFile.sync is removed from version 3 of prettier.

@sandrooco I tried version ^5.0.0-alpha.1 and I got this error:

Cannot read properties of undefined (reading 'parsers')
Occurred while linting path/to/file:1
Rule: "prettier/prettier"

Dependencies:

    "@typescript-eslint/eslint-plugin": "^5.61.0",
    "@typescript-eslint/parser": "^5.61.0",
    "eslint": "8.44.0",
    "eslint-config-next": "^13.4.8",
    "eslint-config-prettier": "^8.8.0",
    "eslint-plugin-cypress": "^2.13.3",
    "eslint-plugin-jest": "^27.2.2",
    "eslint-plugin-no-relative-import-paths": "^1.5.2",
    "eslint-plugin-prettier": "^5.0.0-alpha.1",
    "prettier": "^3.0.0",
    "prettier-plugin-tailwindcss": "^0.3.0",
     "typescript": "^5.1.6",

I realized that my problem is related to the prettier-plugin-tailwindcss package, read more.

skratchdot · 2023-07-05T16:39:17Z

V5 pre-release actually adds support for this. I'm shocked this has been in September last year... @JounQin can you provide information about the future of this package? Thanks for your work!

as mentioned by @sandrooco, the v5 pre-release fixed things for me. changing:

"eslint-plugin-prettier": "^4.2.1",

to:

"eslint-plugin-prettier": "^5.0.0-alpha.1",

in my package.json and re-running npm install fixed things for me.

JounQin · 2023-07-06T01:18:12Z

Please use the alpha version for now, I think we need some feedback before we release the final major version.

npm i -D eslint-plugin-prettier@alpha

JounQin · 2023-07-06T06:33:00Z

@xiaoqiang1999 #562 (comment)

sandrooco · 2023-07-06T07:14:08Z

Thanks for your feedback @JounQin. I was able to successfully run prettier 3.0.0 with the alpha release.

JounQin · 2023-07-06T08:00:19Z

@simPod You need v5.0.0-alpha.2, see #564

simPod · 2023-07-06T09:12:13Z

Smooth, thanks

- cf. prettier/eslint-plugin-prettier#562 - Solution: eslint-plugin-prettier upgrade to v5

alpha until prettier/eslint-plugin-prettier#562

Can't build without either downgrading or upgrading. See [this issue for details](prettier/eslint-plugin-prettier#562).

@hellofanny

## What's the purpose of this pull request? This PR fixes [this](https://github.com/vtex/faststore/actions/runs/6458890810/job/17533535581) issue that happened while publishing packages due to incompatible `eslint-plugin-prettier` versions with prettier 3.x. ## How it works? In #2050 I upgraded the prettier version to 3.x. That caused the issue because `tsdx` has a dependency on an old `eslint-plugin-prettier` version, which is incompatible with `prettier@3`. I'm rolling back the upgrade and fixing the prettier version on the major `2` which makes it difficult for others to make the same mistake as me. In the future, we remove all uses of `tsdx` as it is no longer supported and has gone 3 years without updates. ## How to test it? By merging this! ## References prettier/eslint-plugin-prettier#562 Thanks @hellofanny for noticing the error and investigating it!

ivantrave · 2023-10-16T15:14:39Z

I tried using alpha version and still got this error:

<path_to_npm>/.npm/_npx/15f9efe159c89f49/node_modules/pretty-quick/dist/isSupportedExtension.js:12
  ..._prettier.resolveConfig.sync(file, {
                             ^
TypeError: _prettier.resolveConfig.sync is not a function
    at <path_to_npm>/.npm/_npx/15f9efe159c89f49/node_modules/pretty-quick/dist/isSupportedExtension.js:12:30
    at Array.filter (<anonymous>)
    at _default (<path_to_npm>/.npm/_npx/15f9efe159c89f49/node_modules/pretty-quick/dist/index.js:53:157)
    at Object.<anonymous> (<path_to_npm>/.npm/_npx/15f9efe159c89f49/node_modules/pretty-quick/bin/pretty-quick.js:17:27)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47

in the package json I have:

"eslint-config-prettier": "^8.8.0",
"eslint-plugin-prettier": "^5.0.0-alpha.1",
"prettier": "^3.0.0",

Node version: v16.20.2

Tried with version "eslint-plugin-prettier": "^5.0.1", and "prettier": "^3.0.3" with no luck.

Any suggestion? What may I be missing here?

lehni · 2023-10-16T15:34:06Z

@ivantrave it looks like pretty-quick would need to be updated in order to work with prettier 3. The last release was 2 years ago. You can track the issue here:

prettier/pretty-quick#164

ivantrave · 2023-10-20T10:46:15Z

Thanks for your comment @lehni !

For now, I downgraded to the following versions and it worked:

"eslint-plugin-prettier": "^4.2.1",
"prettier": "^2.8.8",
"pretty-quick": "^3.1.3",

Thanks

konradbjk · 2023-10-31T11:33:27Z

Why this issue is closed, if the error is still not resolved?

For me next.js, prettier 3.0.3 and plugin 5.0.1 do not work either

JounQin · 2023-10-31T11:36:43Z

@konradbjk Then please post another issue with runnable reproduction.

…tier Necessary updates to support Prettier update: prettier/eslint-plugin-prettier#562

* chore(deps-dev): bump prettier from 2.8.8 to 3.1.1 Bumps [prettier](https://github.com/prettier/prettier) from 2.8.8 to 3.1.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.8...3.1.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps-dev): update eslint-config-prettier and eslint-plugin-prettier Necessary updates to support Prettier update: prettier/eslint-plugin-prettier#562 * style: Prettier fixes --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eddybrando Vásquez <[email protected]>

alpha until prettier/eslint-plugin-prettier#562

CyxouD · 2024-05-25T11:54:50Z

Fixed after updating ESLint

 "eslint": "8.57.0",
 "prettier": "3.2.5",
  "eslint-plugin-prettier": "^5.1.3",

IonelLupu · 2024-10-07T09:56:41Z

Fixed after updating ESLint

 "eslint": "8.57.0",
 "prettier": "3.2.5",
  "eslint-plugin-prettier": "^5.1.3",

I can confirm this works for me

shogo82148 mentioned this issue Jul 5, 2023

chore(deps): update dependency prettier to v3 reviewdog/action-golangci-lint#561

Merged

1 task

jonkoops mentioned this issue Jul 5, 2023

Bump prettier from 2.8.8 to 3.0.0 in /js keycloak/keycloak#21458

Closed

Lukas742 mentioned this issue Jul 5, 2023

chore(deps): update dependency prettier to v3 & eslint-plugin-prettier to v5 SAP/ui5-webcomponents-react#4838

Merged

1 task

lubo mentioned this issue Jul 5, 2023

Bump prettier from 2.8.8 to 3.0.0 markavenue/website#60

Closed

lydell mentioned this issue Jul 5, 2023

Prettier 3: prettier/eslint-config-prettier#254

Closed

bdehamer mentioned this issue Jul 5, 2023

Bump the dev-dependencies group with 3 updates sigstore/sigstore-js#593

Closed

richardsimko mentioned this issue Jul 5, 2023

Update dependency prettier to v3 richardsimko/update-tag#23

Merged

1 task

lehni mentioned this issue Jul 5, 2023

Bump prettier from 2.8.8 to 3.0.0 Vincit/objection.js#2454

Merged

This was referenced Jul 5, 2023

chore(deps): update linters (major) thegeeklab/hugo-geekblog#410

Merged

chore(deps): update linters (major) - autoclosed thegeeklab/hugo-geekdoc#659

Merged

westonruter mentioned this issue Jul 5, 2023

Bump prettier from 2.8.7 to 3.0.0 GoogleChromeLabs/pwa-wp#1017

Closed

jpoehnelt mentioned this issue Jul 6, 2023

build: update deps jpoehnelt/semantic-release-replace-plugin#217

Merged

This comment was marked as resolved.

Sign in to view

This was referenced Jul 6, 2023

Bump prettier from 2.8.8 to 3.0.0 labforward/laboperator-workflow-schema#330

Closed

Bump prettier from 2.8.8 to 3.0.0 labforward/markdown-parser#175

Closed

Bump prettier from 2.8.8 to 3.0.0 labforward/laboperator-middleware#123

Closed

ignatiusreza mentioned this issue Jul 6, 2023

Bump prettier from 2.8.8 to 3.0.0 labforward/laboperator-middleware-development#57

Closed

This comment was marked as resolved.

Sign in to view

gagbo mentioned this issue Jul 6, 2023

chore(deps-dev): bump prettier from 2.8.8 to 3.0.0 autometrics-dev/diff-metrics#60

Closed

adnene-guessoum added a commit to adnene-guessoum/Bugtrax that referenced this issue Jul 31, 2023

fix: dependency bug CI pipeline

458c17a

- cf. prettier/eslint-plugin-prettier#562 - Solution: eslint-plugin-prettier upgrade to v5

adnene-guessoum mentioned this issue Jul 31, 2023

fix: dependency issue eslint-plugin-prettier adnene-guessoum/Bugtrax#18

Merged

rbuels mentioned this issue Aug 2, 2023

Add fulltext indexing to ontology store GMOD/Apollo3#244

Merged

mhofman pushed a commit to Agoric/agoric-sdk that referenced this issue Aug 7, 2023

chore(deps): bump eslint-plugin-prettier (alpha)

5f0fbe1

alpha until prettier/eslint-plugin-prettier#562

anilhelvaci pushed a commit to anilhelvaci/agoric-sdk that referenced this issue Aug 16, 2023

chore(deps): bump eslint-plugin-prettier (alpha)

b266b9a

alpha until prettier/eslint-plugin-prettier#562

Madjosz mentioned this issue Aug 23, 2023

Upgrade discord.js version to support new username system codewars/discord-bot#88

Merged

jspn-creative added a commit to jspn-creative/linkedin that referenced this issue Aug 24, 2023

Update prettier eslint plugin

b7db762

Can't build without either downgrading or upgrading. See [this issue for details](prettier/eslint-plugin-prettier#562).

michelegera mentioned this issue Oct 2, 2023

chore(dev-deps): bump prettier related dependencies qonto/ember-prismic-dom#43

Merged

icazevedo mentioned this issue Oct 9, 2023

fix: rollback prettier to 2ˆ to fix publishing issues vtex/faststore#2056

Merged

NikolayDonev mentioned this issue Oct 27, 2023

fix: prettier dev dependancy MentorMate/rn-bootstrap#14

Merged

unlikelyzero mentioned this issue Oct 29, 2023

chore(deps-dev): bump prettier from 2.8.7 to 3.0.3 nasa/openmct#7018

Closed

krpeacock mentioned this issue Nov 27, 2023

chore: locking prettier version for CI dfinity/agent-js#806

Merged

4 tasks

eddybrando added a commit to Qiskit/qiskit.org that referenced this issue Jan 2, 2024

chore(deps-dev): update eslint-config-prettier and eslint-plugin-pret…

e498b86

…tier Necessary updates to support Prettier update: prettier/eslint-plugin-prettier#562

AmeliaLinne mentioned this issue Jan 22, 2024

chore: update prettier and prettier config qlik-oss/picasso.js#827

Merged

anilhelvaci pushed a commit to Jorge-Lopes/agoric-sdk that referenced this issue Feb 16, 2024

chore(deps): bump eslint-plugin-prettier (alpha)

893f666

alpha until prettier/eslint-plugin-prettier#562

runjak mentioned this issue Feb 26, 2024

Fix broken link in docs brianc/node-postgres#3155

Merged

adrienne-deriv mentioned this issue Mar 1, 2024

Fix issue with outside rules and indent rule binary-com/eslint-config-deriv#15

Merged

kalikiana mentioned this issue Apr 2, 2024

Bump prettier from 2.3.2 to 3.2.5 os-autoinst/openQA#5518

Closed

shioju mentioned this issue May 13, 2024

fix: unable to run eslint GovTechSG/oobee#329

Merged

6 tasks

aameraryan mentioned this issue Aug 31, 2024

CSV upload arc53/DocsGPT#1109

Merged

2nikhiltom mentioned this issue Oct 18, 2024

fix(deps): update stylelint and related deps to v16 carbon-design-system/carbon#17770

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue upgrading to Prettier 3 #562

Issue upgrading to Prettier 3 #562

broksonic21 commented Jul 5, 2023

shogo82148 commented Jul 5, 2023

sandrooco commented Jul 5, 2023

isimmons commented Jul 5, 2023

ali4heydari commented Jul 5, 2023 •

edited

Loading

ali4heydari commented Jul 5, 2023

skratchdot commented Jul 5, 2023

JounQin commented Jul 6, 2023 •

edited

Loading

This comment was marked as resolved.

JounQin commented Jul 6, 2023

sandrooco commented Jul 6, 2023

This comment was marked as resolved.

JounQin commented Jul 6, 2023

simPod commented Jul 6, 2023

ivantrave commented Oct 16, 2023 •

edited

Loading

lehni commented Oct 16, 2023

ivantrave commented Oct 20, 2023

konradbjk commented Oct 31, 2023

JounQin commented Oct 31, 2023

CyxouD commented May 25, 2024

IonelLupu commented Oct 7, 2024

Issue upgrading to Prettier 3 #562

Issue upgrading to Prettier 3 #562

Comments

broksonic21 commented Jul 5, 2023

shogo82148 commented Jul 5, 2023

sandrooco commented Jul 5, 2023

isimmons commented Jul 5, 2023

ali4heydari commented Jul 5, 2023 • edited Loading

ali4heydari commented Jul 5, 2023

skratchdot commented Jul 5, 2023

JounQin commented Jul 6, 2023 • edited Loading

This comment was marked as resolved.

JounQin commented Jul 6, 2023

sandrooco commented Jul 6, 2023

This comment was marked as resolved.

JounQin commented Jul 6, 2023

simPod commented Jul 6, 2023

ivantrave commented Oct 16, 2023 • edited Loading

lehni commented Oct 16, 2023

ivantrave commented Oct 20, 2023

konradbjk commented Oct 31, 2023

JounQin commented Oct 31, 2023

CyxouD commented May 25, 2024

IonelLupu commented Oct 7, 2024

ali4heydari commented Jul 5, 2023 •

edited

Loading

JounQin commented Jul 6, 2023 •

edited

Loading

ivantrave commented Oct 16, 2023 •

edited

Loading