Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Exporter uses deprecated field public_name #1910

Open
tribut opened this issue Dec 3, 2024 · 0 comments
Open

JSON Exporter uses deprecated field public_name #1910

tribut opened this issue Dec 3, 2024 · 0 comments
Labels
type: bug Needs fix

Comments

@tribut
Copy link

tribut commented Dec 3, 2024

Problem and impact

When exporting the schedule as JSON (frab compatible), the speakers name is (only) exported as public_name. According to the schema that is also included in this repo, this field is deprecated:

pretalx/src/tests/fixtures/schedule.json

Lines 345 to 348 in d7b427a

"public_name": {
"type": "string",
"deprecated": true,
"$comment": "use name instead"

Expected behaviour

Use name instead of public_name:

pretalx/src/pretalx/schedule/exporters.py

Line 228 in d7b427a

"public_name": person.get_display_name(),

Steps to reproduce

No response

Screenshots

No response

Link

No response

Browser (software, desktop or mobile?) and version

No response

Operating system, dependency versions

No response

Version

No response
@tribut tribut added the type: bug Needs fix label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Needs fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tribut