Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review: Abstrain option even when a field is required #1906

Open
anantshri opened this issue Dec 1, 2024 · 1 comment
Open

Review: Abstrain option even when a field is required #1906

anantshri opened this issue Dec 1, 2024 · 1 comment
Labels
good first issue A default GitHub label inviting first time contributors help wanted A default GitHub label inviting outside help python Pull requests that update Python code size: small Easy and/or quick to do stage: up for grabs type: feature

Comments

@anantshri
Copy link

Problem and impact

Right now abstain option appears when no field is marked as required. "If you require neither a review score nor a review text, reviewers will be offered an additional “Abstain” button when reviewing proposals."

Proposed solution / feature

Abstain option should be a admin controlled field and checking it up would mean reviewers are given an option to abstain from review.

Context or examples

Not every reviewer will be well versed with everything and instead of allowing blank reviews as an org admin i might force a review text to get good quality reviews.

abstain helps reviewers clean the queue yet not see a proposal again and again.
@rixx rixx added size: small Easy and/or quick to do stage: up for grabs help wanted A default GitHub label inviting outside help good first issue A default GitHub label inviting first time contributors python Pull requests that update Python code labels Dec 2, 2024
@rixx
Copy link
Member

rixx commented Dec 2, 2024

That’s a bit rough to build, because abstentions are just null-value votes internally, but I agree that building this could be nice, and I’d be happy to guide and merge a PR to this extent.

I don't think we need to make any actual changes to the settings UI – instead, I think we should just accept abstentions whenever a review score is not required – however, if a review text is required, you have to write a text even when abstaining. The required changes here would be

  • update the help text in the review settings
  • review settings permitting, show the "abstain" button
  • when abstaining, make sure that all other required fields (questions and review text, depending on settings) are still submitted and saved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A default GitHub label inviting first time contributors help wanted A default GitHub label inviting outside help python Pull requests that update Python code size: small Easy and/or quick to do stage: up for grabs type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anantshri @rixx