Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An apostrophe in the wrong place breaks the rendering for cards. #1897

Open
badbadc0ffee opened this issue Nov 25, 2024 · 1 comment
Open

An apostrophe in the wrong place breaks the rendering for cards. #1897

badbadc0ffee opened this issue Nov 25, 2024 · 1 comment
Labels
good first issue A default GitHub label inviting first time contributors help wanted A default GitHub label inviting outside help python Pull requests that update Python code size: small Easy and/or quick to do stage: up for grabs type: bug Needs fix

Comments

@badbadc0ffee
Copy link
Contributor

badbadc0ffee commented Nov 25, 2024 •
edited
Loading

Problem and impact

Printing cards fails when an apostrophe (') is in the wrong place in the abstract text.

The abstract xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' renders fine.
One x more: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' - breaks the card rendering.

Steps to reproduce

  1. Create a Submission with the abstract xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' (x's can be any text, of course, but it must be at least this long)
  2. Try to create the cards printout. → fails
  3. Remove the apostrophe or reduce the length of the text before.
  4. Try to create the cards printout. → works fine
@badbadc0ffee badbadc0ffee added the type: bug Needs fix label Nov 25, 2024
@rixx rixx added size: small Easy and/or quick to do stage: up for grabs help wanted A default GitHub label inviting outside help good first issue A default GitHub label inviting first time contributors python Pull requests that update Python code labels Dec 2, 2024
@rixx
Copy link
Member

rixx commented Dec 2, 2024

Yup, card rendering also breaks when the abstract (markdown-rendered-to-HTML) stops at an inopportune moment leaving a dangling open tag. Happy to merge PRs for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A default GitHub label inviting first time contributors help wanted A default GitHub label inviting outside help python Pull requests that update Python code size: small Easy and/or quick to do stage: up for grabs type: bug Needs fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@badbadc0ffee @rixx