Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependenciesMeta's "inject": true doesn't replace catalog: protocol #8715

Open
2 of 4 tasks
ahkhanjani opened this issue Oct 29, 2024 · 1 comment
Open
2 of 4 tasks
Assignees

Comments

@ahkhanjani
Copy link

ahkhanjani commented Oct 29, 2024

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

9.12.3

Which area(s) of pnpm are affected? (leave empty if unsure)

Dependencies resolver

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

  1. Have a workspaces monorepo.
  2. Have a package that uses catalog: in its dependencies (Let's name it @acme/auth).
  3. Have another app/package that uses @acme/auth with @acme/auth being injected.
  4. Run pnpm i.

Example:

// apps/my-app/package.json
"dependencies": {
  "@acme/auth": "workspace:*",
},
"dependenciesMeta": {
  "@acme/auth": {
    "injected": true
  },
}

// packages/auth/package.json
"dependencies": {
  "react": "catalog:",
}

Describe the Bug

Screenshot 2024-10-30 023641

Here @acme/auth is injected in the app and uses catalogs in its dependencies. Replacing all catalog instances with an actual version fixes the issue. It only happens when @acme/auth uses catalogs directly. There is no problem for its dependencies using catalogs.

Expected Behavior

Resolve this correctly.

Which Node.js version are you using?

22.11.0

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response

@alvis
Copy link
Contributor

alvis commented Nov 20, 2024

I’m experiencing the same issue. @gluxon do you have any insights or suggestions? Thanks.

@gluxon gluxon self-assigned this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants