Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [Feature]: Create Publish action which will bundle and package the solution #385

Open
nicodecleyre opened this issue Jan 2, 2025 · 8 comments
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 🙏 help wanted Open for contributors
Milestone

Comments

@nicodecleyre
Copy link
Contributor

🎯 Aim of the feature

We should add a task "Publish" which will combine the bundle & package solution so it will execute gulp bundle && gulp package-solution.

📷 Images (if possible) with expected result

image

🤔 Additional remarks or comments

This task should handle the publish action for local or production environment. Either two tasks are created, one for publish local and one for publish production. Or we create a publish task and it prompts the user if it should publish for a local or for a production environment

@nicodecleyre nicodecleyre added the ⭐ enhancement New feature or request label Jan 2, 2025
@Adam-it
Copy link
Member

Adam-it commented Jan 2, 2025

@nicodecleyre thank you for this suggestion based on our discussion.
In the initial conversation we were even thinking of combining it with increment version number and deploy.
What do we go even few steps further?
So except adding the gulp publish task we would also add a new action which will be increment + publish + deploy?

As for the question I don't have any hard opinion on that. If you think having a single task with a prompt instead of two separate tasks then I say we may roll with this idea 👍.
Till now we had separated tasks for local and production bundles/packing so that it is easier to find but I agree the list gets longer and longer. Maybe it does make sense to refactor them to a single task w with a prompt question which should be done local or production and default should be local 🤔

@nicodecleyre
Copy link
Contributor Author

hmm, i don't know if we should hard define the increment step in this publish task. As maybe the user opted to change the version number manually. I'm more of a fan of creating a setting as discussed in the other issue, and only if this setting is checked, then the increment prompt should show up in the bundle & publish task. What do you think?

Indeed, as the list gets longer it's best to keep it as clear as possible; i will create a seperate issue to change the bundle & package solution tasks into one for each

@Adam-it
Copy link
Member

Adam-it commented Jan 2, 2025

Indeed, as the list gets longer it's best to keep it as clear as possible; i will create a seperate issue to change the bundle & package solution tasks into one for each

yes lets do that

@Adam-it
Copy link
Member

Adam-it commented Jan 2, 2025

hmm, i don't know if we should hard define the increment step in this publish task. As maybe the user opted to change the version number manually. I'm more of a fan of creating a setting as discussed in the other issue, and only if this setting is checked, then the increment prompt should show up in the bundle & publish task. What do you think?

Sorry maybe I wasn't clear. My idea was not to add increment step to publish but create something additional as well.
So the first thing we could add is a new Task with name publish and which will combine bundle & package like described in this issue 👍

Additionally I was thinking to add a new Action, I don't have a new name for it yet, but the idea would be it would combine increment + publish (bundle & package) + deploy. This could also be a separate issue and discussion. What do you think?

@nicodecleyre
Copy link
Contributor Author

hmm, i don't know if we should hard define the increment step in this publish task. As maybe the user opted to change the version number manually. I'm more of a fan of creating a setting as discussed in the other issue, and only if this setting is checked, then the increment prompt should show up in the bundle & publish task. What do you think?

Sorry maybe I wasn't clear. My idea was not to add increment step to publish but create something additional as well. So the first thing we could add is a new Task with name publish and which will combine bundle & package like described in this issue 👍

Additionally I was thinking to add a new Action, I don't have a new name for it yet, but the idea would be it would combine increment + publish (bundle & package) + deploy. This could also be a separate issue and discussion. What do you think?

Ah, now i get it! Yes, this new action can be a real timesaver! As for a name maybe something like "Deploy all" or "Ship"?

@Adam-it
Copy link
Member

Adam-it commented Jan 2, 2025

"Ship it 🚢"
I like that one 😂👍

@Adam-it
Copy link
Member

Adam-it commented Jan 2, 2025

Ok this issue -with the publish task is clear.
Thanks @nicodecleyre for the awesome discussion and wrapping it up.
Let's open this up. would you like to take it?

@Adam-it Adam-it added 💪 good first issue Good for newcomers 🙏 help wanted Open for contributors and removed 💬 needs discussion labels Jan 2, 2025
@nicodecleyre
Copy link
Contributor Author

Ok this issue -with the publish task is clear. Thanks @nicodecleyre for the awesome discussion and wrapping it up. Let's open this up. would you like to take it?

It's a good first issue, let's see if someone from the community is interested in taking this one 🙏

@Adam-it Adam-it added this to the v4.X milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 🙏 help wanted Open for contributors
Projects
None yet
Development

No branches or pull requests

2 participants