treemap sort

thierryVergult · thierryVergult · commit a66b42dd2ee7 · 2020-09-26T21:46:58.000+02:00
- obey npm lint
- add sort option to treemap (define attribute &amp; coerce in default

Treepad is using the calc from sunburst, so the 1 line code change for  sunburst impacted treemap (sort was not true)
diff --git a/src/traces/sunburst/calc.js b/src/traces/sunburst/calc.js
@@ -192,7 +192,7 @@ exports.calc = function(gd, trace) {
     if(failed) return;
 
     // TODO add way to sort by height also?
-    if (trace.sort) {
+    if(trace.sort) {
         hierarchy.sort(function(a, b) { return b.value - a.value; });
     }
 
diff --git a/src/traces/treemap/attributes.js b/src/traces/treemap/attributes.js
@@ -268,6 +268,7 @@ module.exports = {
             'Sets the positions of the `text` elements.'
         ].join(' ')
     },
+    sort: pieAttrs.sort,
 
     domain: domainAttrs({name: 'treemap', trace: true, editType: 'calc'}),
 };
diff --git a/src/traces/treemap/defaults.js b/src/traces/treemap/defaults.js
@@ -114,6 +114,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         coerce('pathbar.edgeshape');
     }
 
+    coerce('sort');
+
     handleDomainDefaults(traceOut, layout, coerce);
 
     // do not support transforms for now

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ exports.calc = function(gd, trace) {`
`192`	`192`	`if(failed) return;`
`193`	`193`
`194`	`194`	`// TODO add way to sort by height also?`
`195`		`- if (trace.sort) {`
	`195`	`+ if(trace.sort) {`
`196`	`196`	`hierarchy.sort(function(a, b) { return b.value - a.value; });`
`197`	`197`	`}`
`198`	`198`
Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout`
`114`	`114`	`coerce('pathbar.edgeshape');`
`115`	`115`	`}`
`116`	`116`
	`117`	`+ coerce('sort');`
	`118`	`+`
`117`	`119`	`handleDomainDefaults(traceOut, layout, coerce);`
`118`	`120`
`119`	`121`	`// do not support transforms for now`