sunburst: consider empty text string as valid text for texttemplate

antoinerg · antoinerg · commit 6e613d2cf531 · 2019-09-09T18:41:32.000-04:00
diff --git a/src/traces/sunburst/plot.js b/src/traces/sunburst/plot.js
@@ -718,7 +718,7 @@ function formatSliceLabel(pt, trace, fullLayout) {
         obj.color = cdi.color;
     }
     var ptTx = Lib.castOption(trace, cdi.i, 'text');
-    if(Lib.isValidTextValue(ptTx)) obj.text = ptTx;
+    if(Lib.isValidTextValue(ptTx) || ptTx === '') obj.text = ptTx;
     obj.customdata = Lib.castOption(trace, cdi.i, 'customdata');
     return Lib.texttemplateString(txt, obj, fullLayout._d3locale, obj, trace._meta || {});
 }
diff --git a/test/jasmine/tests/sunburst_test.js b/test/jasmine/tests/sunburst_test.js
@@ -1251,4 +1251,14 @@ describe('Test sunburst texttemplate:', function() {
       [['txt: %{label}', '%{text}', 'value: %{value}'], ['txt: Eve', '2', 'value: 13', '', '']],
       ['%{color}', ['rgba(0,0,0,0)', '#1f77b4', '#ff7f0e', '#1f77b4', '#1f77b4']]
     ]);
+
+    // Check for empty string
+    checkTextTemplate([{
+        'type': 'sunburst',
+        'labels': ['Alpha', 'Bravo'],
+        'parents': ['', 'Alpha'],
+        'text': ['description', '']
+    }], 'g.slicetext', [
+      ['%{label} %{text}', ['Alpha description', 'Bravo ']]
+    ]);
 });

Original file line number	Diff line number	Diff line change
`@@ -718,7 +718,7 @@ function formatSliceLabel(pt, trace, fullLayout) {`
`718`	`718`	`obj.color = cdi.color;`
`719`	`719`	`}`
`720`	`720`	`var ptTx = Lib.castOption(trace, cdi.i, 'text');`
`721`		`- if(Lib.isValidTextValue(ptTx)) obj.text = ptTx;`
	`721`	`+ if(Lib.isValidTextValue(ptTx) \|\| ptTx === '') obj.text = ptTx;`
`722`	`722`	`obj.customdata = Lib.castOption(trace, cdi.i, 'customdata');`
`723`	`723`	`return Lib.texttemplateString(txt, obj, fullLayout._d3locale, obj, trace._meta \|\| {});`
`724`	`724`	`}`