Fix forna stylesheet #434
Fix forna stylesheet #434
Conversation
package.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| "dependencies": { | |||
| "circos": "git+https://github.com/matthewchan15/circosJS.git#matthewchan15-zoom-pan-svg", | |||
| "fast-memoize": "^2.5.1", | |||
| "fornac": "^1.1.8", | |||
| "fornac": "git://github.com/plotly/fornac.git", | |||
There was a problem hiding this comment.
Let's put a hash here, so if and when we upgrade it's intentional :)
Same for all the git-referenced packages in fact. Even the circos branch reference isn't unique, a commit hash is better (and while I'm looking at this... much as we appreciate @matthewchan15's work, circos should probably be moved into the plotly namespace as well)
| @@ -83,6 +83,7 @@ export default class FornaContainer extends Component { | |||
| return ( | |||
| <div | |||
| id={this.props.id} | |||
| className="forna-container" | |||
There was a problem hiding this comment.
If you're able to rebuild fornac, it would be better to add this class there - probably here adding .classed('forna-container', true) - so that (a) we don't have this hidden requirement that our fornac only be run through dash-bio (and the otherwise inexplicable presence of this className), and (b) we can PR back to the original repo.
If it's any sort of a pain figuring out how to build fornac, don't worry about it, we can leave it as you have it.
There was a problem hiding this comment.
we can get rid of this line now, right?
There was a problem hiding this comment.
Ah that's right! Fixed in 8cad5f4.
shammamah-zz
force-pushed
the
fix-forna-stylesheet
branch
from
1fb0d27 to
d9e174a
Compare
shammamah-zz
force-pushed
the
fix-forna-stylesheet
branch
from
1942afb to
d42c42b
Compare
Co-Authored-By: alexcjohnson <[email protected]>
shammamah-zz
force-pushed
the
fix-forna-stylesheet
branch
from
77cae26 to
45183b0
Compare
About
The
fornacpackage includes stylesheets that apply to all SVG elements (see https://github.com/ViennaRNA/fornac/blob/9771d6d79d400e334bb306387d5fc795097ff94d/app/styles/fornac.css#L1); this package was forked to https://github.com/plotly/fornac with an additional.forna-containerclass selector prepended to each selector in the included stylesheets.The
FornaContainercomponent in this library was accordingly updated to include aclassNameproperty of.forna-containerso that the styles from the original library would still apply.