Use form attribute in the boolean nested hidden field

Fixes #1545
heartcombo · Oct 6, 2018 · 87ad6f7 · 87ad6f7
1 parent 67d8df4
commit 87ad6f7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,13 +1,14 @@
 ## Unreleased
 
 ### Enhancements
-* Guess input type more carefully. [sringling](https://github.com/sringling)
-* Allow custom error on forms without model. [victorperez](https://github.com/victorperez)
+* Guess input type more carefully. [@sringling](https://github.com/sringling)
+* Allow custom error on forms without model. [@victorperez](https://github.com/victorperez)
 
 ### Bug fix
-* Improve disabled option to input_field. [betelgeuse](https://github.com/betelgeuse)
+* Improve disabled option to input_field. [@betelgeuse](https://github.com/betelgeuse)
 * Memoize `input_html_classes` in `SimpleForm::Inputs::Base`. [@RigoTheDev](https://github.com/RigoTheDev)
 * Fix column type citext HTML5 input type bug. [@brucew](https://github.com/brucew)
+* Use form attribute in the nested boolean hidden field when it is given. [@feliperenan](https://github.com/feliperenan)
 
 ## 4.0.1
 

diff --git a/lib/simple_form/inputs/boolean_input.rb b/lib/simple_form/inputs/boolean_input.rb
@@ -63,6 +63,7 @@ def build_hidden_field_for_checkbox
         return "" if !include_hidden? || !unchecked_value
         options = { value: unchecked_value, id: nil, disabled: input_html_options[:disabled] }
         options[:name] = input_html_options[:name] if input_html_options.key?(:name)
+        options[:form] = input_html_options[:form] if input_html_options.key?(:form)
 
         @builder.hidden_field(attribute_name, options)
       end

diff --git a/test/inputs/boolean_input_test.rb b/test/inputs/boolean_input_test.rb
@@ -107,6 +107,14 @@ class BooleanInputTest < ActionView::TestCase
     end
   end
 
+  test 'input boolean with nested generates a disabled hidden field with the form attribute when it is given' do
+    swap SimpleForm, boolean_style: :nested do
+      with_input_for @user, :active, :boolean, input_html: { form: 'form_id' }
+
+      assert_select "input[type=hidden][form=form_id]+ label.boolean > input.boolean"
+    end
+  end
+
   test 'input accepts changing boolean style to nested through given options' do
     with_input_for @user, :active, :boolean, boolean_style: :nested
     assert_select 'label[for=user_active]', 'Active'