Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CircleCI with GitHub Actions #996

Merged
merged 9 commits into from
Jan 29, 2021
Merged

Replace CircleCI with GitHub Actions #996

merged 9 commits into from
Jan 29, 2021

Conversation

StanczakDominik
Copy link
Member

@StanczakDominik StanczakDominik commented Jan 29, 2021 •
edited
Loading

  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

@StanczakDominik StanczakDominik marked this pull request as ready for review January 29, 2021 15:04
@StanczakDominik
Copy link
Member Author

The CircleCI build error here is a sign that we've successfully removed the config :) Upon merging we'll have to

@StanczakDominik StanczakDominik mentioned this pull request Jan 29, 2021
Merged
namurphy
namurphy reviewed Jan 29, 2021
View reviewed changes
Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really close! I can probably review and approve this pretty quickly once the doc build error is fixed (about pandoc needing to be installed).

.github/workflows/testing.yml
Comment on lines +67 to +70
- name: Documentation
os: ubuntu-latest
python: 3.8
toxenv: build_docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really straightforward code. I thought it was going to be a lot more complicated. Nice!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly I'm not saving any artifacts from this, just having this scream at us about warnings! RTD does the doc output now, so there's no reason to duplicate that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transitioning to tox a while ago paid off!

@StanczakDominik
Copy link
Member Author

And that's a successful doc build :)

namurphy
namurphy approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye, CircleCI!

@StanczakDominik StanczakDominik merged commit f0d0b29 into PlasmaPy:master Jan 29, 2021
@StanczakDominik StanczakDominik deleted the remove-circleci branch January 29, 2021 18:58
@StanczakDominik StanczakDominik added this to the 0.6.0 milestone Mar 12, 2021
@namurphy namurphy added the GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namurphy namurphy namurphy approved these changes

Assignees
No one assigned
Labels
GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) testing
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@StanczakDominik @namurphy