-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests from Travis to Github Actions #952
Move tests from Travis to Github Actions #952
Conversation
Codecov Report
@@ Coverage Diff @@
## master #952 +/- ##
==========================================
- Coverage 96.29% 96.25% -0.04%
==========================================
Files 62 62
Lines 5715 5661 -54
==========================================
- Hits 5503 5449 -54
Misses 212 212
Continue to review full report at Codecov.
|
e79e273
to
d1d6d2a
Compare
8b4acb9
to
93e38b8
Compare
Okay, this is beginning to look good. The reason for this is that Travis is beginning to retreat from the open source market because people were abusing it to mine crypto etc. I thus replaced it with GitHub actions (all hail to our new Microsoft overlords!). In our setup Travis doesn't do much that Azure didn't, so it got relegated to cron jobs a while back. I'm pretty sure I've got that covered. Come to think of it, though, the Actions set up does look nicer than the Azure one (it seems like it's going to be easier to parse errors this way), so I'd actually be in favor of using Actions for PRs instead. The only thing I'd keep from Azure (for now) is wheel builds for releases, but I'm pretty sure I'm going to be able to automate that soon as well. |
wrt code coverage, I'm still not sure whether it works correctly but it'd be much easier to set up "on the spot" rather than semi-blindly as I'm trying to do now. I also have another PR on my fork that disables PR builds on Azure. Basically, all the Azure check entries would disappear. This is nice because the tests become much more user friendly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far! I like the idea of using GitHub Actions for most of our tests. I only took a quick look at this today and will try to look at it again before the meeting tomorrow when I have fewer things due by 5 pm Pacific time.
|
||
jobs: | ||
build: | ||
if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.event.head_commit.message, '[skip github]')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add to the developer docs that we can put [ci skip]
, etc. in commit messages to skip the CI stuff.
I'll explain later, need tests to start working first...