Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests from Travis to Github Actions #952

Merged
merged 20 commits into from
Nov 24, 2020

Conversation

StanczakDominik
Copy link
Member

I'll explain later, need tests to start working first...

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #952 (faa7668) into master (46414cb) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
- Coverage   96.29%   96.25%   -0.04%     
==========================================
  Files          62       62              
  Lines        5715     5661      -54     
==========================================
- Hits         5503     5449      -54     
  Misses        212      212              
Impacted Files Coverage Δ
plasmapy/plasma/plasma_base.py 72.22% <0.00%> (-3.39%) ⬇️
plasmapy/simulation/abstractions.py 75.00% <0.00%> (-2.78%) ⬇️
plasmapy/plasma/sources/openpmd_hdf5.py 78.88% <0.00%> (-1.12%) ⬇️
plasmapy/analysis/fit_functions.py 97.72% <0.00%> (-0.06%) ⬇️
plasmapy/simulation/particletracker.py 98.30% <0.00%> (-0.03%) ⬇️
plasmapy/utils/pytest_helpers/pytest_helpers.py 92.64% <0.00%> (-0.03%) ⬇️
plasmapy/particles/ionization_state.py 92.93% <0.00%> (-0.03%) ⬇️
plasmapy/particles/particle_class.py 96.57% <0.00%> (-0.01%) ⬇️
plasmapy/formulary/braginskii.py 99.72% <0.00%> (-0.01%) ⬇️
plasmapy/particles/decorators.py 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46414cb...4c36299. Read the comment docs.

@StanczakDominik StanczakDominik marked this pull request as ready for review November 22, 2020 12:10
@StanczakDominik
Copy link
Member Author

StanczakDominik commented Nov 22, 2020

Okay, this is beginning to look good.

The reason for this is that Travis is beginning to retreat from the open source market because people were abusing it to mine crypto etc. I thus replaced it with GitHub actions (all hail to our new Microsoft overlords!).

In our setup Travis doesn't do much that Azure didn't, so it got relegated to cron jobs a while back. I'm pretty sure I've got that covered. Come to think of it, though, the Actions set up does look nicer than the Azure one (it seems like it's going to be easier to parse errors this way), so I'd actually be in favor of using Actions for PRs instead.

The only thing I'd keep from Azure (for now) is wheel builds for releases, but I'm pretty sure I'm going to be able to automate that soon as well. I'm still figuring out code coverage.

cc @rocco8773 @namurphy

@StanczakDominik
Copy link
Member Author

wrt code coverage, I'm still not sure whether it works correctly but it'd be much easier to set up "on the spot" rather than semi-blindly as I'm trying to do now.

I also have another PR on my fork that disables PR builds on Azure. Basically, all the Azure check entries would disappear. This is nice because the tests become much more user friendly.

Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far! I like the idea of using GitHub Actions for most of our tests. I only took a quick look at this today and will try to look at it again before the meeting tomorrow when I have fewer things due by 5 pm Pacific time.

tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved

jobs:
build:
if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.event.head_commit.message, '[skip github]')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add to the developer docs that we can put [ci skip], etc. in commit messages to skip the CI stuff.

@StanczakDominik StanczakDominik merged commit da588f8 into PlasmaPy:master Nov 24, 2020
@StanczakDominik StanczakDominik deleted the travis-to-gh-actions branch February 18, 2021 09:13
@namurphy namurphy added CI Related to continuous integration GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) testing labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to continuous integration GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants