Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of sub-modules on the Formulary documentation page #867

Merged
merged 4 commits into from
Jul 14, 2020

Conversation

rocco8773
Copy link
Member

@rocco8773 rocco8773 commented Jul 13, 2020

I felt the current documentation page for the formulary module was difficult to ready. The sub-module list is rather busy and not alphabetized (see Current Layout below), making it hard to look at and find what you want. So, in the New Layout I made the following changes...

  1. Simplified the toctree names so the sidebar just shows the label for the sub-module and not the full module syntax.
  2. Hide the toctree directive and created a table with the simplified module name and the module syntax. (I think this greatly improve the readability)
  3. Put the nbgallery into an Examples sub-section, so the galleries appear in an Examples drop-down in the sidebar.

Current Layout

image


New Layout

image

@rocco8773 rocco8773 added docs PlasmaPy Docs at http://docs.plasmapy.org plasmapy.formulary Related to the plasmapy.formulary subpackage labels Jul 13, 2020
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #867 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #867   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files          59       59           
  Lines        5225     5225           
=======================================
  Hits         5020     5020           
  Misses        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72443f3...695d2d6. Read the comment docs.

@rocco8773 rocco8773 marked this pull request as ready for review July 13, 2020 22:53
Copy link
Member

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clean and lovely :) LGTM! I take it we're clear to merge?

Copy link
Member

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this so much you get a second approval

@StanczakDominik StanczakDominik merged commit b63e82f into PlasmaPy:master Jul 14, 2020
@rocco8773 rocco8773 deleted the formulary-table-docs branch October 23, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org plasmapy.formulary Related to the plasmapy.formulary subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants